Changeset 95243 in vbox for trunk/src/VBox/VMM

Timestamp:

Jun 9, 2022 1:18:05 PM (3 years ago)

Author:

vboxsync

Message:

VMM/vmR3SetRuntimeErrorCommon: Don't call VMR3Suspend unless the VM is running. bugref:10111

File:

• trunk/src/VBox/VMM/VMMR3/VM.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMR3/VM.cpp

@@ -1181 +1181 @@
      * something was racing us in one way or the other, there will be no more
      * calls and thus the state assertion below is not going to annoy anyone.
+     *
+     * Note! Changes to the state transition here needs to be reflected in the
+     *       checks in vmR3SetRuntimeErrorCommon!
      */
     if (pVCpu->idCpu == pVM->cCpus - 1)
@@ -4018 +4021 @@
                                 vmR3SetRuntimeErrorChangeState, NULL);
     else if (fFlags & VMSETRTERR_FLAGS_SUSPEND)
-        rc = VMR3Suspend(pUVM, VMSUSPENDREASON_RUNTIME_ERROR);
+    {
+        /* Make sure we don't call VMR3Suspend when we shouldn't.  As seen in
+           @bugref{10111} multiple runtime error may be flagged when we run out
+           of disk space or similar, so don't freak out VMR3Suspend by calling
+           it in an invalid VM state. */
+        VMSTATE enmStateCur = pVM->enmVMState;
+        if (enmStateCur == VMSTATE_RUNNING || enmStateCur == VMSTATE_RUNNING_LS)
+            rc = VMR3Suspend(pUVM, VMSUSPENDREASON_RUNTIME_ERROR);
+    }
     else
         rc = VINF_SUCCESS;