Changeset 95298 in vbox for trunk/src/VBox/HostServices

Timestamp:

Jun 16, 2022 7:57:27 AM (2 years ago)

Author:

vboxsync

Message:

Shared Folders/Host service: When a client disconnects, make sure that outstanding change waits are being canceled. See comment for details.

File:

• trunk/src/VBox/HostServices/SharedFolders/VBoxSharedFoldersSvc.cpp (modified) (1 diff)

trunk/src/VBox/HostServices/SharedFolders/VBoxSharedFoldersSvc.cpp

@@ -180 +180 @@
 {
     RT_NOREF1(u32ClientID);
-    int rc = VINF_SUCCESS;
     SHFLCLIENTDATA *pClient = (SHFLCLIENTDATA *)pvClient;
 
-    Log(("SharedFolders host service: disconnected, u32ClientID = %u\n", u32ClientID));
+    /* When a client disconnects, make sure that outstanding change waits are being canceled.
+     *
+     * Usually this will be done actively by VBoxService on the guest side when shutting down,
+     * but the VM could be reset without having VBoxService the chance of cancelling those waits.
+     *
+     * This in turn will eat up the call completion handle restrictions on the HGCM host side, throwing assertions. */
+    int rc = vbsfMappingsCancelChangesWaits(pClient);
+
+    Log(("SharedFolders host service: disconnected, u32ClientID = %u, rc = %Rrc\n", u32ClientID, rc));
 
     vbsfDisconnect(pClient);