Changeset 95337 in vbox

Timestamp:

Jun 21, 2022 8:50:20 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

151929

Message:

Main/Settings.cpp: Use RTCString::trucate to reduce guest property values to a length of GUEST_PROP_MAX_VALUE_LEN-1. bugref:10185

File:

• trunk/src/VBox/Main/xml/Settings.cpp (modified) (1 diff)

trunk/src/VBox/Main/xml/Settings.cpp

@@ -4673 +4673 @@
             /* In order to pass validation, guest property value length (including '\0') in bytes
              * should be less than GUEST_PROP_MAX_VALUE_LEN. Chop it down to an appropriate length. */
-            /** @todo r=bird: Should add a RTCString method for this, as this may create a
-             *        invalid UTF-8 encoding if we chop up a UTF-8 sequence. */
-            Assert(prop.strValue.length() + 1 > GUEST_PROP_MAX_VALUE_LEN);
-            prop.strValue.mutableRaw()[GUEST_PROP_MAX_VALUE_LEN - 1] = '\0';
-            prop.strValue.jolt();
+            prop.strValue.truncate(GUEST_PROP_MAX_VALUE_LEN - 1 /*terminator*/);
         }
         else if (RT_FAILURE(rc))