Changeset 95361 in vbox

Timestamp:

Jun 23, 2022 9:47:01 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

151955

Message:

VMM/CPUM: Pass thru the POPCNT CPUID flag. Corrected ABM passthru. bugref:9898

File:

• trunk/src/VBox/VMM/VMMR3/CPUMR3CpuId.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMR3/CPUMR3CpuId.cpp

@@ -1391 +1391 @@
                            //| X86_CPUID_FEATURE_ECX_X2APIC - turned on later by the device if enabled.
                            | PASSTHRU_FEATURE_TODO(pConfig->enmMovBe, X86_CPUID_FEATURE_ECX_MOVBE)
-                           | PASSTHRU_FEATURE_TODO(pConfig->enmPopCnt, X86_CPUID_FEATURE_ECX_POPCNT)
+                           | PASSTHRU_FEATURE(pConfig->enmPopCnt, pHstFeat->fPopCnt, X86_CPUID_FEATURE_ECX_POPCNT)
                            //| X86_CPUID_FEATURE_ECX_TSCDEADL - not implemented yet.
                            | PASSTHRU_FEATURE_TODO(pConfig->enmAesNi, X86_CPUID_FEATURE_ECX_AES)
@@ -1593 +1593 @@
                                /* Note: This could prevent teleporting from AMD to Intel CPUs! */
                                | X86_CPUID_AMD_FEATURE_ECX_CR8L         /* expose lock mov cr0 = mov cr8 hack for guests that can use this feature to access the TPR. */
-                               | PASSTHRU_FEATURE_TODO(pConfig->enmAbm,       X86_CPUID_AMD_FEATURE_ECX_ABM)
+                               | PASSTHRU_FEATURE(pConfig->enmAbm,       pHstFeat->fAbm, X86_CPUID_AMD_FEATURE_ECX_ABM)
                                | PASSTHRU_FEATURE_TODO(pConfig->enmSse4A,     X86_CPUID_AMD_FEATURE_ECX_SSE4A)
                                | PASSTHRU_FEATURE_TODO(pConfig->enmMisAlnSse, X86_CPUID_AMD_FEATURE_ECX_MISALNSSE)
@@ -2873 +2873 @@
     AssertLogRelRCReturn(rc, rc);
 
-    /** @cfgm{/CPUM/IsaExts/POPCNT, isaextcfg, depends}
-     * Whether to expose the POPCNT instructions to the guest.  For the time
-     * being the default is to only do this for VMs with nested paging and AMD-V or
-     * unrestricted guest mode.
-     */
-    rc = cpumR3CpuIdReadIsaExtCfg(pVM, pIsaExts, "POPCNT", &pConfig->enmPopCnt, fNestedPagingAndFullGuestExec);
+    /** @cfgm{/CPUM/IsaExts/POPCNT, isaextcfg, true}
+     * Whether to expose the POPCNT instructions to the guest.
+     */
+    rc = cpumR3CpuIdReadIsaExtCfg(pVM, pIsaExts, "POPCNT", &pConfig->enmPopCnt, CPUMISAEXTCFG_ENABLED_SUPPORTED);
     AssertLogRelRCReturn(rc, rc);