Changeset 95411 in vbox for trunk/src/VBox

Timestamp:

Jun 28, 2022 6:50:10 PM (3 years ago)

Author:

vboxsync

Message:

Linux host and guest drivers: fix clang warnings, bugref:10247.

Location:

trunk/src/VBox

Files:

• Additions/linux/drm/vbox_ttm.c (modified) (3 diffs)
• Additions/linux/sharedfolders/dirops.c (modified) (1 diff)
• Additions/linux/sharedfolders/utils.c (modified) (2 diffs)
• Additions/linux/sharedfolders/vfsmod.c (modified) (2 diffs)
• HostDrivers/VBoxNetFlt/linux/VBoxNetFlt-linux.c (modified) (1 diff)
• Installer/linux/Makefile-footer.gmk (modified) (1 diff)
• Runtime/r0drv/linux/timer-r0drv-linux.c (modified) (1 diff)

trunk/src/VBox/Additions/linux/drm/vbox_ttm.c

@@ -796 +796 @@
 {
         struct drm_file *file_priv;
-        struct vbox_private *vbox;
         int ret = -EINVAL;
 
@@ -803 +802 @@
 
         file_priv = filp->private_data;
-        vbox = file_priv->minor->dev->dev_private;
 
 #if RTLNX_VER_MIN(5,14,0) || RTLNX_RHEL_RANGE(8,6, 8,99)
@@ -810 +808 @@
         ret = drm_gem_mmap(filp, vma);
 #else
-        ret = ttm_bo_mmap(filp, vma, &vbox->ttm.bdev);
+        ret = ttm_bo_mmap(filp, vma, &file_priv->minor->dev->dev_private->ttm.bdev);
 #endif
         return ret;

trunk/src/VBox/Additions/linux/sharedfolders/dirops.c

@@ -830 +830 @@
             pReq->Create.CreateParms.Info.Attr.fMode         = (S_ISDIR(mode) ? RTFS_TYPE_DIRECTORY : RTFS_TYPE_FILE)
                                                              | sf_access_permissions_to_vbox(mode);
-            pReq->Create.CreateParms.Info.Attr.enmAdditional = RTFSOBJATTRADD_NOTHING;
+            pReq->Create.CreateParms.Info.Attr.enmAdditional = SHFLFSOBJATTRADD_NOTHING;
 
             SFLOGFLOW(("%s calling VbglR0SfHostReqCreate(%s, %#x)\n", pszPrefix, path->String.ach, pReq->Create.CreateParms.CreateFlags));

trunk/src/VBox/Additions/linux/sharedfolders/utils.c

@@ -48 +48 @@
         char       *out             = name;
         size_t      out_bound_len   = name_bound_len - 1;
-        size_t      out_len         = 0;
 
         while (in_bound_len) {
@@ -64 +63 @@
                     out           += cbOutEnc;
                     out_bound_len -= cbOutEnc;
-                    out_len       += cbOutEnc;
 
                     in            += cbInEnc;

trunk/src/VBox/Additions/linux/sharedfolders/vfsmod.c

@@ -194 +194 @@
     if ((unsigned)info->length >= RT_UOFFSETOF(struct vbsf_mount_info_new, enmCacheMode)) {
         switch (info->enmCacheMode) {
-            case kVbsfCacheMode_Default:
+            case kVbsfCacheMode_Default: RT_FALL_THRU();
             case kVbsfCacheMode_Strict:
                 break;
@@ -1140 +1140 @@
             seq_printf(m, ",dirbuf=%u", pSuperInfo->cbDirBuf);
         switch (pSuperInfo->enmCacheMode) {
-            default: AssertFailed();
+            default: AssertFailed(); RT_FALL_THRU();
             case kVbsfCacheMode_Strict:
                 break;

trunk/src/VBox/HostDrivers/VBoxNetFlt/linux/VBoxNetFlt-linux.c

@@ -1703 +1703 @@
     {
         struct net_device  *pDev;
-        PINTNETTRUNKSWPORT  pSwitchPort;
         unsigned int        fFeatures;
 
         RTSpinlockAcquire(pThis->hSpinlock);
 
-        pSwitchPort = pThis->pSwitchPort; /* this doesn't need to be here, but it doesn't harm. */
         pDev = ASMAtomicUoReadPtrT(&pThis->u.s.pDev, struct net_device *);
         if (pDev)

trunk/src/VBox/Installer/linux/Makefile-footer.gmk

@@ -39 +39 @@
  ifeq ($(shell expr $(KERN_VER) : '[23]\.'),0)
   VBOXMOD_0_KFLAGS  += -Werror -Wall -Wno-array-bounds
+  # Disable this for DEBUG clang builds. There are parts of kernel which will use __builtin_frame_address with argument > 0.
+  ifneq ($(LLVM),)
+   VBOXMOD_0_KFLAGS += -Wno-frame-address
+  endif
  endif
 endif

trunk/src/VBox/Runtime/r0drv/linux/timer-r0drv-linux.c

@@ -545 +545 @@
             case RTTIMERLNXSTATE_STOPPING:
             case RTTIMERLNXSTATE_MP_STOPPING:
-                enmState = RTTIMERLNXSTATE_STOPPED;
+                enmState = RTTIMERLNXSTATE_STOPPED; RT_FALL_THRU();
             case RTTIMERLNXSTATE_STOPPED:
                 break;