Changeset 95459 in vbox

Timestamp:

Jun 30, 2022 12:42:30 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

152066

Message:

DIS: We only need one OP_CRC32 value. bugref:9898 bugref:6251

Location:

trunk

Files:

• include/VBox/disopcode.h (modified) (1 diff)
• src/VBox/Disassembler/DisasmTables.cpp (modified) (2 diffs)

trunk/include/VBox/disopcode.h

@@ -489 +489 @@
     OP_MOVBEGM,
     OP_MOVBEMG,
-    OP_CRC32GDEB,
-    OP_CRC32GDEY,
+    OP_CRC32,
     OP_POPCNT,
     OP_TZCNT,

trunk/src/VBox/Disassembler/DisasmTables.cpp

@@ -1584 +1584 @@
        it should be %Gd (always dword regardless of operand-size attribute), but from the description of the command
        it is clear that REX.W prefix can change this size to 64 bit, therefore it is set to %Gy. Seems to be a mistake. */
-    OP("crc32 %Gy,%Eb",   IDX_ParseModRM,   IDX_UseModRM,   0,   OP_CRC32GDEB,    OP_PARM_Gy,   OP_PARM_Eb,   OP_PARM_NONE,   DISOPTYPE_HARMLESS),
-    OP("crc32 %Gy,%Ey",   IDX_ParseModRM,   IDX_UseModRM,   0,   OP_CRC32GDEY,    OP_PARM_Gy,   OP_PARM_Ey,   OP_PARM_NONE,   DISOPTYPE_HARMLESS),
+    /** @todo r=bird: While the destination can be a 64-bit register, it is
+     *        always treated like a dword register given that the upper half is
+     *        always cleared.  So, it is really just a convenience for a more
+     *        natural syntax when using a 64-bit source register. */
+    OP("crc32 %Gy,%Eb",   IDX_ParseModRM,   IDX_UseModRM,   0,   OP_CRC32,    OP_PARM_Gy,   OP_PARM_Eb,   OP_PARM_NONE,   DISOPTYPE_HARMLESS),
+    OP("crc32 %Gy,%Ey",   IDX_ParseModRM,   IDX_UseModRM,   0,   OP_CRC32,    OP_PARM_Gy,   OP_PARM_Ey,   OP_PARM_NONE,   DISOPTYPE_HARMLESS),
     INVALID_OPCODE,
     INVALID_OPCODE,
@@ -1607 +1611 @@
        it should be %Gd (always dword regardless of operand-size attribute), but from the description of the command
        it is clear that REX.W prefix can change this size to 64 bit, therefore it is set to %Gy. Seems to be a mistake. */
-    OP("crc32 %Gy,%Eb",   IDX_ParseModRM,   IDX_UseModRM,   0,   OP_CRC32GDEB,    OP_PARM_Gy,   OP_PARM_Eb,   OP_PARM_NONE,   DISOPTYPE_HARMLESS),
-    OP("crc32 %Gy,%Ew",   IDX_ParseModRM,   IDX_UseModRM,   0,   OP_CRC32GDEY,    OP_PARM_Gy,   OP_PARM_Ew,   OP_PARM_NONE,   DISOPTYPE_HARMLESS),
+    OP("crc32 %Gy,%Eb",   IDX_ParseModRM,   IDX_UseModRM,   0,   OP_CRC32,    OP_PARM_Gy,   OP_PARM_Eb,   OP_PARM_NONE,   DISOPTYPE_HARMLESS),
+    OP("crc32 %Gy,%Ew",   IDX_ParseModRM,   IDX_UseModRM,   0,   OP_CRC32,    OP_PARM_Gy,   OP_PARM_Ew,   OP_PARM_NONE,   DISOPTYPE_HARMLESS),
     INVALID_OPCODE,
     INVALID_OPCODE,