Changeset 95485 in vbox for trunk/src/VBox/ValidationKit/bootsectors/bs3kit

Timestamp:

Jul 3, 2022 1:58:25 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

152099

Message:

ValKit/bs3-cpu-instr-3: Simple tests for pshufw, [v]pshufhw, [v]pshuflw and [v]pshufd. Added parameter to Bs3ExtCtxSetMm to control what we do with the 16-bit bytes above the mmx register part, so we can opt to clear it when setting source and destination register to check that register writes always sets these bits. bugref:9898

Location:

trunk/src/VBox/ValidationKit/bootsectors/bs3kit

Files:

• bs3-cmn-ExtCtxSetMm.c (modified) (2 diffs)
• bs3kit.h (modified) (2 diffs)

trunk/src/VBox/ValidationKit/bootsectors/bs3kit/bs3-cmn-ExtCtxSetMm.c

@@ -33 +33 @@
 
 #undef Bs3ExtCtxSetMm
-BS3_CMN_DEF(bool, Bs3ExtCtxSetMm,(PBS3EXTCTX pExtCtx, uint8_t iReg, uint64_t uValue))
+BS3_CMN_DEF(bool, Bs3ExtCtxSetMm,(PBS3EXTCTX pExtCtx, uint8_t iReg, uint64_t uValue, BS3EXTCTXTOPMM enmTop))
 {
     AssertCompileMembersAtSameOffset(BS3EXTCTX, Ctx.x87.aRegs, BS3EXTCTX, Ctx.x.x87.aRegs);
@@ -41 +41 @@
             case BS3EXTCTXMETHOD_FXSAVE:
             case BS3EXTCTXMETHOD_XSAVE:
-                /* pxor mm1, mm2 on 10980XE sets mm1's sign and exponent to all 1's. */
-                pExtCtx->Ctx.x87.aRegs[iReg].au16[4]    = UINT16_MAX;
-                pExtCtx->Ctx.x87.aRegs[iReg].mmx        = uValue;
+                pExtCtx->Ctx.x87.aRegs[iReg].mmx = uValue;
+                if (enmTop == BS3EXTCTXTOPMM_SET || enmTop == BS3EXTCTXTOPMM_ZERO)
+                    pExtCtx->Ctx.x87.aRegs[iReg].au16[4] = enmTop == BS3EXTCTXTOPMM_SET ? UINT16_MAX : 0;
                 return true;
 
             case BS3EXTCTXMETHOD_ANCIENT:
-                pExtCtx->Ctx.Ancient.regs[iReg].au16[4] = UINT16_MAX; /* see above */
-                pExtCtx->Ctx.Ancient.regs[iReg].mmx     = uValue;
+                pExtCtx->Ctx.Ancient.regs[iReg].mmx = uValue;
+                if (enmTop == BS3EXTCTXTOPMM_SET || enmTop == BS3EXTCTXTOPMM_ZERO)
+                    pExtCtx->Ctx.Ancient.regs[iReg].au16[4] = enmTop == BS3EXTCTXTOPMM_SET ? UINT16_MAX : 0;
                 return true;
         }

trunk/src/VBox/ValidationKit/bootsectors/bs3kit/bs3kit.h

@@ -2989 +2989 @@
 BS3_CMN_PROTO_STUB(uint64_t, Bs3ExtCtxGetMm,(PCBS3EXTCTX pExtCtx, uint8_t iReg));
 
+/** What to do about the 16-bit above the MM QWORD. */
+typedef enum BS3EXTCTXTOPMM
+{
+    /** Invalid zero value. */
+    BS3EXTCTXTOPMM_INVALID = 0,
+    /** Set to 0FFFFh like real CPUs typically does when updating an MM register. */
+    BS3EXTCTXTOPMM_SET,
+    /** Set to zero. */
+    BS3EXTCTXTOPMM_ZERO,
+    /** Don't change the value, leaving it as-is. */
+    BS3EXTCTXTOPMM_AS_IS,
+    /** End of valid values. */
+    BS3EXTCTXTOPMM_END
+} BS3EXTCTXTOPMM;
+
 /**
  * Sets the value of YMM register number @a iReg in @a pExtCtx to @a pValue.
@@ -2996 +3011 @@
  * @param   iReg            The register to set.
  * @param   uValue          The new register value.
- */
-BS3_CMN_PROTO_STUB(bool, Bs3ExtCtxSetMm,(PBS3EXTCTX pExtCtx, uint8_t iReg, uint64_t uValue));
+ * @param   enmTop          What to do about the 16-bit value above the MM
+ *                          QWord.
+ */
+BS3_CMN_PROTO_STUB(bool, Bs3ExtCtxSetMm,(PBS3EXTCTX pExtCtx, uint8_t iReg, uint64_t uValue, BS3EXTCTXTOPMM enmTop));
 
 /**