Changeset 95592 in vbox for trunk/src/VBox/Devices/Network

Timestamp:

Jul 11, 2022 10:32:41 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

152228

Message:

PDM/network, Network/virtio: Add sanity checking. bugref:10240

File:

• trunk/src/VBox/Devices/Network/DevVirtioNet_1_0.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Network/DevVirtioNet_1_0.cpp

@@ -1695 +1695 @@
     pGso->cbHdrsTotal = pPktHdr->uHdrLen;
     pGso->cbMaxSeg    = pPktHdr->uGsoSize;
+    /* Mark GSO frames with zero MSS as PDMNETWORKGSOTYPE_INVALID, so they will be ignored by send. */
+    if (pPktHdr->uGsoType != VIRTIONET_HDR_GSO_NONE && pPktHdr->uGsoSize == 0)
+        pGso->u8Type = PDMNETWORKGSOTYPE_INVALID;
     return pGso;
 }
@@ -2616 +2619 @@
                 pGso->cbHdrsSeg = pPktHdr->uChksumStart;
                 break;
+            case PDMNETWORKGSOTYPE_INVALID:
+                LogFunc(("%s ignoring invalid GSO frame\n", pThis->szInst));
+                return VERR_INVALID_PARAMETER;
         }
         /* Update GSO structure embedded into the frame */