Changeset 95624 in vbox for trunk/src/VBox/Runtime/common/crypto

Timestamp:

Jul 13, 2022 8:31:41 PM (3 years ago)

Author:

vboxsync

Message:

IPRT/RTAsn1,RTCrSpc: Generate setter functions for RTASN1TMPL_MEMBER_OPT_XTAG_EX and RTASN1TMPL_MEMBER_OPT_ITAG_EX members. Added setter prototypes to the spc.h header. bugref:8691

File:

• trunk/src/VBox/Runtime/common/crypto/pkcs7-sign.cpp (modified) (4 diffs)

trunk/src/VBox/Runtime/common/crypto/pkcs7-sign.cpp

@@ -136 +136 @@
                 {
                     /*
-                     * Do the signing.
+                     * Use CMS_sign with CMS_PARTIAL to start a extended the signing process.
                      */
                     /* Create a ContentInfo we can modify using CMS_sign w/ CMS_PARTIAL. */
@@ -147 +147 @@
                     if (pCms != NULL)
                     {
-                        /* Set encapsulated content type if present in the auth attribs. */
+                        /*
+                         * Set encapsulated content type if present in the auth attribs.
+                         */
                         uint32_t iAuthAttrSkip = UINT32_MAX;
                         for (uint32_t i = 0; i < pAdditionalAuthenticatedAttribs->cItems && RT_SUCCESS(rc); i++)
@@ -176 +178 @@
                         if (RT_SUCCESS(rc))
                         {
-                            /* Add a signer. */
+                            /*
+                             * Add a signer.
+                             */
                             CMS_SignerInfo *pSignerInfo = CMS_add1_signer(pCms, pOsslSigner, pEvpPrivateKey, pEvpMd, fOsslSign);
                             if (pSignerInfo)
                             {
-                                /* Add additional attributes, skipping the content type found above. */
+                                /*
+                                 * Add additional attributes, skipping the content type if found above.
+                                 */
                                 if (pAdditionalAuthenticatedAttribs)
                                     for (uint32_t i = 0; i < pAdditionalAuthenticatedAttribs->cItems && RT_SUCCESS(rc); i++)
@@ -198 +204 @@
                                 if (RT_SUCCESS(rc))
                                 {
-                                    /* Finally, produce the signed data. */
+                                    /*
+                                     * Finalized and actually sign the data.
+                                     */
                                     rc = CMS_final(pCms, pOsslData, NULL /*dcont*/, fOsslSign);
                                     if (rc > 0)