Changeset 9563 in vbox for trunk/src/VBox

Timestamp:

Jun 10, 2008 11:01:33 AM (17 years ago)

Author:

vboxsync

Message:

Cache the KeQueryActiveProcessors() result at init (see crash reading the mask at DPC_LEVEL in SUPDrv-win.cpp).

Location:

trunk/src/VBox/Runtime/r0drv/nt

Files:

• initterm-r0drv-nt.cpp (modified) (3 diffs)
• internal-r0drv-nt.h (added)
• mp-r0drv-nt.cpp (modified) (5 diffs)
• mpnotification-r0drv-nt.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/r0drv/nt/initterm-r0drv-nt.cpp

@@ -29 +29 @@
  */
 
-
 /*******************************************************************************
 *   Header Files                                                               *
@@ -36 +35 @@
 #include <iprt/err.h>
 #include <iprt/assert.h>
+#include <iprt/mp.h>
 #include "internal/initterm.h"
+#include "internal-r0drv-nt.h"
+
+
+/*******************************************************************************
+*   Global Variables                                                           *
+*******************************************************************************/
+/** The Nt CPU set.
+ * KeQueryActiveProcssors() cannot be called at all IRQLs and therefore we'll
+ * have to cache it. Fortunately, Nt doesn't really support taking CPUs offline
+ * or online. It's first with W2K8 that support for adding / onlining cpus at
+ * runtime is (officially) supported. Once we start caring about this, we'll
+ * simply use the native MP event callback and update this variable as cpus
+ * comes online.
+ */
+RTCPUSET g_rtMpNtCpuSet;
+
 
 int rtR0InitNative(void)
 {
+    /*
+     * Init the Nt cpu set.
+     */
+    KAFFINITY ActiveProcessors = KeQueryActiveProcessors();
+    RTCpuSetEmpty(&g_rtMpNtCpuSet);
+    RTCpuSetFromU64(&g_rtMpNtCpuSet, ActiveProcessors);
+
+#if 0 /* W2K8 support */
+    return RTR0MpNotificationInit(NULL);
+#else
     return VINF_SUCCESS;
+#endif
 }
 
@@ -46 +73 @@
 void rtR0TermNative(void)
 {
+#if 0 /* W2K8 support */
+    RTR0MpNotificationTerm(NULL);
+#endif
 }
 

trunk/src/VBox/Runtime/r0drv/nt/mp-r0drv-nt.cpp

@@ -40 +40 @@
 #include <iprt/asm.h>
 #include "r0drv/mp-r0drv.h"
+#include "internal-r0drv-nt.h"
 
 
@@ -95 +96 @@
         return false;
 
-    /** @todo this must be done at init time as it's not safe under all circumstances (braindead OS design). */
+#if 0 /* this isn't safe at all IRQLs (great work guys) */
     KAFFINITY Mask = KeQueryActiveProcessors();
     return !!(Mask & RT_BIT_64(idCpu));
+#else
+    return RTCpuSetIsMember(&g_rtMpNtCpuSet, idCpu);
+#endif
 }
 
@@ -125 +129 @@
 RTDECL(PRTCPUSET) RTMpGetOnlineSet(PRTCPUSET pSet)
 {
+#if 0 /* this isn't safe at all IRQLs (great work guys) */
     KAFFINITY Mask = KeQueryActiveProcessors();
     return RTCpuSetFromU64(pSet, Mask);
+#else
+    *pSet = g_rtMpNtCpuSet;
+    return pSet;
+#endif
 }
 
@@ -255 +264 @@
 }
 
+
 RTDECL(int) RTMpOnAll(PFNRTMPWORKER pfnWorker, void *pvUser1, void *pvUser2)
 {
@@ -260 +270 @@
 }
 
+
 RTDECL(int) RTMpOnOthers(PFNRTMPWORKER pfnWorker, void *pvUser1, void *pvUser2)
 {
     return rtMpCall(pfnWorker, pvUser1, pvUser2, RT_NT_CPUID_OTHERS, 0);
 }
+
 
 RTDECL(int) RTMpOnSpecific(RTCPUID idCpu, PFNRTMPWORKER pfnWorker, void *pvUser1, void *pvUser2)

trunk/src/VBox/Runtime/r0drv/nt/mpnotification-r0drv-nt.cpp

@@ -39 +39 @@
 #include <iprt/cpuset.h>
 #include "r0drv/mp-r0drv.h"
+#include "internal-r0drv-nt.h"
 
 
@@ -88 +89 @@
         case KeProcessorAddCompleteNotify:
             rtMpNotificationDoCallbacks(RTMPEVENT_ONLINE, idCpu);
+            RTCpuSetAdd(&g_rtMpNtCpuSet, idCpu);
             break;