Changeset 95715 in vbox for trunk/src/VBox/ValidationKit/testdriver

Timestamp:

Jul 18, 2022 4:37:45 PM (3 years ago)

Author:

vboxsync

Message:

Validation Kit/vboxinstaller: Tweaked the stub loader MSI logging path for VBox >= 6.1 to use a deterministic location, which then can be uploaded to the test manager.

File:

• trunk/src/VBox/ValidationKit/testdriver/vboxinstaller.py (modified) (2 diffs)

trunk/src/VBox/ValidationKit/testdriver/vboxinstaller.py

@@ -912 +912 @@
         if sVBoxInstallPath is not None:
             asArgs.extend(['INSTALLDIR="%s"' % (sVBoxInstallPath,)]);
-
+        if self.fpApiVer >= 6.1:
+            # We need to explicitly specify the location, otherwise the log would end up at a random location.
+            sLogFile = os.path.join(tempfile.gettempdir(), 'VBoxInstallLog.txt');
+            asArgs.extend(['--msi-log-file', sLogFile]);
+        else: # Prior to 6.1 the location was hardcoded.
+            sLogFile = os.path.join(tempfile.gettempdir(), 'VirtualBox', 'VBoxInstallLog.txt');
         fRc2, iRc = self._sudoExecuteSync(asArgs);
         if fRc2 is False:
@@ -920 +925 @@
                 reporter.error('Installer failed, exit code: %s' % (iRc,));
             fRc = False;
-
-        sLogFile = os.path.join(tempfile.gettempdir(), 'VirtualBox', 'VBoxInstallLog.txt');
         if os.path.isfile(sLogFile):
             reporter.addLogFile(sLogFile, 'log/installer', "Verbose MSI installation log file");