Changeset 95731 in vbox

Timestamp:

Jul 19, 2022 7:18:09 PM (2 years ago)

Author:

vboxsync

Message:

Windows Additions/Installer: Fix documentation of CmdExecute (parameter "optional" was described incorrectly), and make the legacy VBox TS CA install optional (it will fail on reinstalling the cert). bugref:8691

Location:

trunk/src/VBox/Additions/WINNT/Installer

Files:

• VBoxGuestAdditionsExternal.nsh (modified) (1 diff)
• VBoxGuestAdditionsW2KXP.nsh (modified) (1 diff)

trunk/src/VBox/Additions/WINNT/Installer/VBoxGuestAdditionsExternal.nsh

@@ -23 +23 @@
 ;
 ; @param   Command line (full qualified and quoted).
-; @param   If set to "true" the installer aborts if the external program reports
-;          an exit code other than 0, "false" just prints a warning and continues
+; @param   If set to "false" the installer aborts if the external program reports
+;          an exit code other than 0, "true" just prints a warning and continues
 ;          execution.
 ;

trunk/src/VBox/Additions/WINNT/Installer/VBoxGuestAdditionsW2KXP.nsh

@@ -175 +175 @@
     FILE "$%PATH_OUT%\bin\additions\vbox-legacy-timestamp-ca.cer"
     FILE "$%PATH_OUT%\bin\additions\VBoxCertUtil.exe"
-    ${CmdExecute} "$\"$INSTDIR\cert\VBoxCertUtil.exe$\" add-trusted-publisher --root $\"$INSTDIR\cert\vbox-legacy-timestamp-ca.cer$\"" "false"
-    ${CmdExecute} "$\"$INSTDIR\cert\VBoxCertUtil.exe$\" display-all" "false"
+    ${CmdExecute} "$\"$INSTDIR\cert\VBoxCertUtil.exe$\" add-trusted-publisher --root $\"$INSTDIR\cert\vbox-legacy-timestamp-ca.cer$\"" "true"
+    ${CmdExecute} "$\"$INSTDIR\cert\VBoxCertUtil.exe$\" display-all" "true"
   ${EndIf}
 !endif