Changeset 95774 in vbox for trunk/src/VBox

Timestamp:

Jul 21, 2022 11:42:04 AM (2 years ago)

Author:

vboxsync

Message:

FE/Qt/Ds: bugref:9286: UIRecordingSettingsEditor: Handle supported video/audio capturing features dynamically.

Location:

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors

Files:

• UIRecordingSettingsEditor.cpp (modified) (3 diffs)
• UIRecordingSettingsEditor.h (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIRecordingSettingsEditor.cpp

@@ -31 +31 @@
 #include "UIFilmContainer.h"
 #include "UIRecordingSettingsEditor.h"
+
+/* COM includes: */
+#include "CSystemProperties.h"
 
 /* Defines: */
@@ -132 +135 @@
     {
         m_enmMode = enmMode;
-        if (m_pComboMode)
-        {
-            const int iIndex = m_pComboMode->findData(QVariant::fromValue(enmMode));
-            if (iIndex != -1)
-                m_pComboMode->setCurrentIndex(iIndex);
-        }
+        populateComboMode();
+        updateWidgetVisibility();
     }
 }
@@ -822 +821 @@
 }
 
+void UIRecordingSettingsEditor::populateComboMode()
+{
+    if (m_pComboMode)
+    {
+        /* Clear combo first of all: */
+        m_pComboMode->clear();
+
+        /* Load currently supported recording features: */
+        CSystemProperties comProperties = uiCommon().virtualBox().GetSystemProperties();
+        int iSupportedFlag = 0;
+        foreach (const KRecordingFeature &enmFeature, comProperties.GetSupportedRecordingFeatures())
+            iSupportedFlag |= enmFeature;
+        m_supportedValues.clear();
+        if (!iSupportedFlag)
+            m_supportedValues << UISettingsDefs::RecordingMode_None;
+        else
+        {
+            if (   (iSupportedFlag & KRecordingFeature_Video)
+                && (iSupportedFlag & KRecordingFeature_Audio))
+                m_supportedValues << UISettingsDefs::RecordingMode_VideoAudio;
+            if (iSupportedFlag & KRecordingFeature_Video)
+                m_supportedValues << UISettingsDefs::RecordingMode_VideoOnly;
+            if (iSupportedFlag & KRecordingFeature_Audio)
+                m_supportedValues << UISettingsDefs::RecordingMode_AudioOnly;
+        }
+
+        /* Make sure requested value if sane is present as well: */
+        if (   m_enmMode != UISettingsDefs::RecordingMode_Max
+            && !m_supportedValues.contains(m_enmMode))
+            m_supportedValues.prepend(m_enmMode);
+
+        /* Update combo with all the supported values: */
+        foreach (const UISettingsDefs::RecordingMode &enmType, m_supportedValues)
+            m_pComboMode->addItem(QString(), QVariant::fromValue(enmType));
+
+        /* Look for proper index to choose: */
+        const int iIndex = m_pComboMode->findData(QVariant::fromValue(m_enmMode));
+        if (iIndex != -1)
+            m_pComboMode->setCurrentIndex(iIndex);
+
+        /* Retranslate finally: */
+        retranslateUi();
+    }
+}
+
+void UIRecordingSettingsEditor::updateWidgetVisibility()
+{
+    /* Only the Audio stuff can be totally disabled, so we will add the code for hiding Audio stuff only: */
+    const bool fAudioSettingsVisible =    m_supportedValues.isEmpty()
+                                       || m_supportedValues.contains(UISettingsDefs::RecordingMode_AudioOnly);
+    m_pWidgetAudioQualitySettings->setVisible(fAudioSettingsVisible);
+    m_pLabelAudioQuality->setVisible(fAudioSettingsVisible);
+}
+
 void UIRecordingSettingsEditor::updateWidgetAvailability()
 {

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIRecordingSettingsEditor.h

@@ -140 +140 @@
     void prepareConnections();
 
+    /** Populates mode combo-box. */
+    void populateComboMode();
+
+    /** Updates widget visibility. */
+    void updateWidgetVisibility();
     /** Updates widget availability. */
     void updateWidgetAvailability();
@@ -164 +169 @@
         bool  m_fScreenOptionsAvailable;
 
+        /** Holds the list of supported modes. */
+        QVector<UISettingsDefs::RecordingMode>  m_supportedValues;
         /** Holds the mode. */
-        UISettingsDefs::RecordingMode  m_enmMode;
+        UISettingsDefs::RecordingMode           m_enmMode;
 
         /** Holds the folder. */