Changeset 95808 in vbox

Timestamp:

Jul 25, 2022 1:00:05 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

152530

Message:

FE/Qt/Ds: bugref:10244: Hiding recording settings tab and status-bar indicator if no recording features supported.

Location:

trunk/src/VBox/Frontends/VirtualBox/src

Files:

• globals/UICommon.cpp (modified) (1 diff)
• globals/UICommon.h (modified) (1 diff)
• runtime/UIIndicatorsPool.cpp (modified) (1 diff)
• settings/editors/UIRecordingSettingsEditor.cpp (modified) (1 diff)
• settings/machine/UIMachineSettingsDisplay.cpp (modified) (1 diff)

trunk/src/VBox/Frontends/VirtualBox/src/globals/UICommon.cpp

@@ -2306 +2306 @@
 }
 
+int UICommon::supportedRecordingFeatures() const
+{
+    int iSupportedFlag = 0;
+    CSystemProperties comProperties = virtualBox().GetSystemProperties();
+    foreach (const KRecordingFeature &enmFeature, comProperties.GetSupportedRecordingFeatures())
+        iSupportedFlag |= enmFeature;
+    return iSupportedFlag;
+}
+
 /* static */
 QString UICommon::helpFile()

trunk/src/VBox/Frontends/VirtualBox/src/globals/UICommon.h

@@ -455 +455 @@
         /** Generates tool-tip for passed USB @a comWebcam. */
         static QString usbToolTip(const CHostVideoInputDevice &comWebcam);
+    /** @} */
+
+    /** @name COM: Recording stuff.
+     * @{ */
+        /** Returns supported recording features flag. */
+        int supportedRecordingFeatures() const;
     /** @} */
 

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIIndicatorsPool.cpp

@@ -1492 +1492 @@
     /* Acquire status-bar restrictions: */
     m_restrictions = gEDataManager->restrictedStatusBarIndicators(uiCommon().managedVMUuid());
+    /* Make sure 'Recording' is restricted as well if no features supported: */
+    if (   !m_restrictions.contains(IndicatorType_Recording)
+        && !uiCommon().supportedRecordingFeatures())
+        m_restrictions << IndicatorType_Recording;
+
     /* Remove restricted indicators: */
     foreach (const IndicatorType &indicatorType, m_restrictions)

trunk/src/VBox/Frontends/VirtualBox/src/settings/editors/UIRecordingSettingsEditor.cpp

@@ -829 +829 @@
 
         /* Load currently supported recording features: */
-        CSystemProperties comProperties = uiCommon().virtualBox().GetSystemProperties();
-        int iSupportedFlag = 0;
-        foreach (const KRecordingFeature &enmFeature, comProperties.GetSupportedRecordingFeatures())
-            iSupportedFlag |= enmFeature;
+        const int iSupportedFlag = uiCommon().supportedRecordingFeatures();
         m_supportedValues.clear();
         if (!iSupportedFlag)

trunk/src/VBox/Frontends/VirtualBox/src/settings/machine/UIMachineSettingsDisplay.cpp

@@ -781 +781 @@
     m_pEditorVRDESettings->setVRDEOptionsAvailable(isMachineOffline() || isMachineSaved());
 
+    /* Polish 'Recording' visibility: */
+    m_pTabWidget->setTabVisible(m_pTabWidget->indexOf(m_pTabRecording), uiCommon().supportedRecordingFeatures());
     /* Polish 'Recording' availability: */
     m_pTabRecording->setEnabled(isMachineInValidMode());