Changeset 95867 in vbox for trunk/src/VBox

Timestamp:

Jul 27, 2022 1:24:58 AM (2 years ago)

Author:

vboxsync

Message:

VBoxTray/VBoxDisplay.h: This header file name clashes with one in ../include/, so please merge this (and a bunch of others ones) into VBoxTray.h or VBoxSeamless.h because this is a waste of time to have to wonder about which file is being includes and what the code means. My preference would be to rename VBoxTray.h to VBoxTrayInternal.h and all but except maybe VBoxDnD.h into it.

File:

• trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxDisplay.h (modified) (1 diff)

trunk/src/VBox/Additions/WINNT/VBoxTray/VBoxDisplay.h

@@ -22 +22 @@
 #endif
 
+/** @todo r=bird: This file has the same name as ../include/VBoxDisplay.h
+ *        which some of the VBoxTray source files also wish to include.
+ *
+ *        The result is a certifiable mess. To quote a Tina Fey's character in
+ *        Ponyo: "BAKA BAKA BAKA BAKA BAKA BAKA BAKA BAKA BAKA BAKA BAKA!!!"
+ *
+ *        There are too many 'ing header files here.  Most of them can be merged
+ *        into VBoxTray.h (or a VBoxTrayInternal.h file).
+ *
+ */
+
+
 DWORD VBoxDisplayGetCount();
 DWORD VBoxDisplayGetConfig(const DWORD NumDevices, DWORD *pDevPrimaryNum, DWORD *pNumDevices, DISPLAY_DEVICE *paDisplayDevices, DEVMODE *paDeviceModes);