Changeset 95936 in vbox for trunk/src

Timestamp:

Jul 29, 2022 8:32:38 AM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

152691

Message:

Validation Kit/tdAddBasic1.py: Only force installing the timestamp CA on Windows guests >= Windows Server 2016. This otherwise would sabotage testing older guests where the Guest Additions installer should care of this automatically. bugref:8691

File:

• trunk/src/VBox/ValidationKit/tests/additions/tdAddBasic1.py (modified) (1 diff)

trunk/src/VBox/ValidationKit/tests/additions/tdAddBasic1.py

@@ -409 +409 @@
         asArgs = [ sExe, '/S', '/l', '/with_autologon' ];
 
+        # Determine if we need to force installing the legacy timestamp CA to make testing succeed.
+        # Note: Don't force installing when the Guest Additions installer should do this automatically,
+        #       i.e, only force it for Windows Server 2016 and up.
+        fForceInstallTimeStampCA = False;
+        if self.fpApiVer >= 6.1 \
+           and oTestVm.getNonCanonicalGuestOsType() \
+              in [ 'Windows2016', 'Windows2019', 'Windows2022', 'Windows11' ]:
+              fForceInstallTimeStampCA = True;
+
         # As we don't have a console command line to parse for the Guest Additions installer (only a message box) and
         # unknown / unsupported parameters get ignored with silent installs anyway, we safely can add the following parameter(s)
         # even if older Guest Addition installers might not support those.
-        if self.fpApiVer >= 6.1:
+        if fForceInstallTimeStampCA:
             asArgs.extend([ '/install_timestamp_ca' ]);