Changeset 96172 in vbox for trunk/src/VBox/Frontends/VBoxManage

Timestamp:

Aug 12, 2022 1:27:46 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

152980

Message:

Recording/Main: Changed IRecordingScreenSettings::features attribute to get/set a safe array of RecordingFeature entries instead of an anonymous ULONG. Makes it much easier to use. bugref:10275

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageInfo.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageInfo.cpp

@@ -2846 +2846 @@
             ULONG idScreen;
             CHECK_ERROR_RET(screenSettings, COMGETTER(Id)(&idScreen), hrc);
-            ULONG fFeatures;
-            CHECK_ERROR_RET(screenSettings, COMGETTER(Features)(&fFeatures), hrc);
+            com::SafeArray<RecordingFeature_T> vecFeatures;
+            CHECK_ERROR_RET(screenSettings, COMGETTER(Features)(ComSafeArrayAsOutParam(vecFeatures)), hrc);
             ULONG Width;
             CHECK_ERROR_RET(screenSettings, COMGETTER(VideoWidth)(&Width), hrc);
@@ -2867 +2867 @@
             BOOL fRecordAudio = FALSE;
 # endif
-            Utf8Str strOptions(bstrOptions);
-            size_t pos = 0;
-            com::Utf8Str key, value;
-            while ((pos = strOptions.parseKeyValue(key, value, pos)) != com::Utf8Str::npos)
-            {
-                if (key.compare("vc_enabled", Utf8Str::CaseInsensitive) == 0)
-                {
-                    fRecordVideo = value.compare("true", Utf8Str::CaseInsensitive) == 0;
-                }
-                else if (key.compare("ac_enabled", Utf8Str::CaseInsensitive) == 0)
-                {
-# ifdef VBOX_WITH_AUDIO_RECORDING
-                    fRecordAudio = value.compare("true", Utf8Str::CaseInsensitive) == 0;
-# endif
-                }
+            for (size_t f = 0; f < vecFeatures.size(); ++f)
+            {
+                if (vecFeatures[f] == RecordingFeature_Audio)
+                    fRecordAudio = TRUE;
+                else if (vecFeatures[f] == RecordingFeature_Video)
+                    fRecordVideo = TRUE;
             }