Changeset 96176 in vbox

Timestamp:

Aug 12, 2022 2:20:09 PM (2 years ago)

Author:

vboxsync

Message:

Recording: Implemented support for Vorbis codec (provided by libvorbis, not enabled by default yet). This also makes all the codec handling more abstract by using a simple codec wrapper, to keep other places free from codec-specific as much as possible. Initial implementation works and output files are being recognized by media players, but there still are some timing bugs to resolve, as well as optimizing the performance [build fix]. bugref:10275

Location:

trunk/src/VBox/Main

Files:

• include/RecordingInternals.h (modified) (1 diff)
• include/RecordingStream.h (modified) (2 diffs)
• src-client/RecordingCodec.cpp (modified) (5 diffs)

trunk/src/VBox/Main/include/RecordingInternals.h

@@ -444 +444 @@
 typedef std::list<RecordingBlock *> RecordingBlockList;
 
-#ifdef VBOX_WITH_AUDIO_RECORDING
 int recordingCodecCreateAudio(PRECORDINGCODEC pCodec, RecordingAudioCodec_T enmAudioCodec);
-#endif
 int recordingCodecCreateVideo(PRECORDINGCODEC pCodec, RecordingVideoCodec_T enmVideoCodec);
 int recordingCodecInit(const PRECORDINGCODEC pCodec, const PRECORDINGCODECCALLBACKS pCallbacks, const settings::RecordingScreenSettings &Settings);

trunk/src/VBox/Main/include/RecordingStream.h

@@ -126 +126 @@
     uint16_t GetID(void) const { return this->uScreenID; };
 #ifdef VBOX_WITH_AUDIO_RECORDING
-    const PRECORDINGCODEC GetAudioCodec(void) { return &this->CodecAudio; };
+    PRECORDINGCODEC GetAudioCodec(void) { return &this->CodecAudio; };
 #endif
-    const PRECORDINGCODEC GetVideoCodec(void) { return &this->CodecVideo; };
+    PRECORDINGCODEC GetVideoCodec(void) { return &this->CodecVideo; };
     bool IsLimitReached(uint64_t msTimestamp) const;
     bool IsReady(void) const;
@@ -195 +195 @@
     uint64_t            tsStartMs;
 
-#ifdef VBOX_WITH_AUDIO_RECORDING
     /** Audio codec instance data to use. */
     RECORDINGCODEC                    CodecAudio;
-#endif
     /** Video codec instance data to use. */
     RECORDINGCODEC                    CodecVideo;

trunk/src/VBox/Main/src-client/RecordingCodec.cpp

@@ -535 +535 @@
 *********************************************************************************************************************************/
 
-#ifdef VBOX_WITH_AUDIO_RECORDING
 /**
  * Initializes an audio codec.
@@ -595 +594 @@
     return vrc;
 }
-#endif /* VBOX_WITH_AUDIO_RECORDING */
 
 /**
@@ -649 +647 @@
 
 #ifdef VBOX_WITH_AUDIO_RECORDING
-/**s
+/**
  * Lets an audio codec parse advanced options given from a string.
  *
@@ -686 +684 @@
     return VINF_SUCCESS;
 }
+#endif
 
 /**
@@ -740 +739 @@
     return vrc;
 }
-#endif /* VBOX_WITH_AUDIO_RECORDING */
 
 /**