Changeset 96177 in vbox

Timestamp:

Aug 12, 2022 2:27:58 PM (2 years ago)

Author:

vboxsync

Message:

Recording: Implemented support for Vorbis codec (provided by libvorbis, not enabled by default yet). This also makes all the codec handling more abstract by using a simple codec wrapper, to keep other places free from codec-specific as much as possible. Initial implementation works and output files are being recognized by media players, but there still are some timing bugs to resolve, as well as optimizing the performance [build fix]. bugref:10275

Location:

trunk/src/VBox/Main

Files:

• include/RecordingInternals.h (modified) (1 diff)
• src-client/RecordingCodec.cpp (modified) (3 diffs)

trunk/src/VBox/Main/include/RecordingInternals.h

@@ -289 +289 @@
     /** Timestamp (in ms) of the last frame was encoded. */
     uint64_t            uLastTimeStampMs;
+    /** Number of encoding errors. */
+    uint64_t            cEncErrors;
 
 #ifdef VBOX_WITH_STATISTICS /** @todo Register these values with STAM. */
     struct
     {
-        /** Number of encoding errors. */
-        uint64_t        cEncErrors;
         /** Number of frames encoded. */
         uint64_t        cEncBlocks;

trunk/src/VBox/Main/src-client/RecordingCodec.cpp

@@ -157 +157 @@
     if (rcv != VPX_CODEC_OK)
     {
-        if (pCodec->Stats.cEncErrors++ < 64) /** @todo Make this configurable. */
+        if (pCodec->cEncErrors++ < 64) /** @todo Make this configurable. */
             LogRel(("Recording: Failed to encode video frame: %s\n", vpx_codec_err_to_string(rcv)));
         return VERR_RECORDING_ENCODING_FAILED;
     }
 
-    pCodec->Stats.cEncErrors = 0;
+    pCodec->cEncErrors = 0;
 
     vpx_codec_iter_t iter = NULL;
@@ -775 +775 @@
         pCodec->Parms.enmType       = RECORDINGCODECTYPE_VIDEO;
         pCodec->Parms.enmVideoCodec = enmVideoCodec;
-
-#ifdef VBOX_WITH_STATISTICS
-        pCodec->Stats.cEncBlocks = 0;
-        pCodec->Stats.msEncTotal = 0;
-#endif
     }
 
@@ -802 +797 @@
     else
         AssertFailedStmt(vrc = VERR_NOT_SUPPORTED);
+
+    if (RT_SUCCESS(vrc))
+    {
+        pCodec->cEncErrors       = 0;
+#ifdef VBOX_WITH_STATISTICS
+        pCodec->Stats.cEncBlocks = 0;
+        pCodec->Stats.msEncTotal = 0;
+#endif
+    }
+
     return vrc;
 }