Changeset 96178 in vbox

Timestamp:

Aug 12, 2022 2:35:52 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

152986

Message:

Recording: Implemented support for Vorbis codec (provided by libvorbis, not enabled by default yet). This also makes all the codec handling more abstract by using a simple codec wrapper, to keep other places free from codec-specific as much as possible. Initial implementation works and output files are being recognized by media players, but there still are some timing bugs to resolve, as well as optimizing the performance [build fix]. bugref:10275

Location:

trunk/src/VBox/Main

Files:

• include/RecordingInternals.h (modified) (2 diffs)
• src-client/RecordingStream.cpp (modified) (1 diff)

trunk/src/VBox/Main/include/RecordingInternals.h

@@ -27 +27 @@
 #include <iprt/types.h> /* drag in stdint.h before vpx does it. */
 
+#include "VBox/com/string.h"
 #include "VBox/com/VirtualBox.h"
 #include "VBox/settings.h"
@@ -113 +114 @@
      * @param   strOptions          Options string to parse.
      */
-    DECLCALLBACKMEMBER(int, pfnParseOptions, (PRECORDINGCODEC pCodec, const Utf8Str &strOptions));
+    DECLCALLBACKMEMBER(int, pfnParseOptions, (PRECORDINGCODEC pCodec, const com::Utf8Str &strOptions));
 
     /**

trunk/src/VBox/Main/src-client/RecordingStream.cpp

@@ -935 +935 @@
 
 /* static */
-int RecordingStream::codecWriteDataCallback(PRECORDINGCODEC pCodec, const void *pvData, size_t cbData, void *pvUser)
+DECLCALLBACK(int) RecordingStream::codecWriteDataCallback(PRECORDINGCODEC pCodec, const void *pvData, size_t cbData, void *pvUser)
 {
     RT_NOREF(pCodec);