Changeset 96212 in vbox for trunk/src/VBox/Main

Timestamp:

Aug 15, 2022 9:35:10 AM (2 years ago)

Author:

vboxsync

Message:

Enabled audio recording again, now using Vorbis (libvorbis) as the default codec. Still work in progress [Windows build fix, see @todo]. bugref:10275

File:

• trunk/src/VBox/Main/Makefile.kmk (modified) (1 diff)

trunk/src/VBox/Main/Makefile.kmk

@@ -1029 +1029 @@
   endif
   ifdef VBOX_WITH_LIBOGG
-   VBoxC_SDKS += VBOX_OGG
-   VBoxC_DEFS += VBOX_WITH_LIBOGG
+   VBOX_MAIN_DEFS += VBOX_WITH_LIBOGG
+   VBoxC_SDKS     += VBOX_OGG
+   VBoxC_DEFS     += VBOX_WITH_LIBOGG
+   ## @todo We need this for libvorbis down below. Remove once the libvorbis @todo is resolved.
+   VBoxSVC_SDKS   += VBOX_OGG
   endif
   ifdef VBOX_WITH_LIBVORBIS
-   VBoxC_SDKS += VBOX_VORBIS
-   VBoxC_DEFS += VBOX_WITH_LIBVORBIS
-   # Needed in VBoxSVC for ISystemProperties.
-   src-server/SystemPropertiesImpl.cpp_DEFS += VBOX_WITH_LIBVORBIS
+   VBOX_MAIN_DEFS += VBOX_WITH_LIBVORBIS
+   VBoxC_SDKS     += VBOX_VORBIS
+   ## @todo We also need to specify this for VBoxSVC, as we need to have VBOX_WITH_LIBVORBIS defined
+   ##       for SystemProperties::getSupportedRecordingAudioCodecs().
+   #        SystemPropertiesImpl_DEFS += VBOX_WITH_LIBVORBIS didn't work for precompiled headers on Windows --
+   #        needs to be solved properly so that we can remove the following _SDKS from VBoxSVC again.
+   VBoxSVC_SDKS   += VBOX_VORBIS
   endif
   VBoxC_SOURCES += src-client/DrvAudioRec.cpp