Changeset 96269 in vbox

Timestamp:

Aug 17, 2022 4:47:58 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

153083

Message:

IPRT: Don't include the windows error defines in the static libraries as it isn't used too much (compared to the VBox ones) and takes up quite a bit of space (30% for the valkit tstUtf8.exe). We can lookup windows error codes manually when looking into logs/errors including them. If we find some way of stripping them down and/or implement better compression, we can reconsider this. bugref:10195

Location:

trunk/src/VBox/Runtime

Files:

• Makefile.kmk (modified) (2 diffs)
• win/errmsgwin.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/Makefile.kmk

@@ -1782 +1782 @@
 # RuntimeR3 - Static Runtime for Ring-3 executables.
 #
+# We drop the windows error defines here for reason of size. The valkit tstUtf8
+# was reduced by 175KB, from 600KB to 425KB (about 30%). Come up with a way of
+# stripping it down or compressing it better and it can be added back.
+# - 2022-08-17, bird.
+#
 RuntimeR3_TEMPLATE = VBoxR3Static
 RuntimeR3_EXTENDS  = RuntimeBaseR3
+#RuntimeR3_DEFS.win = $(RuntimeBaseR3_DEFS.win) IPRT_NO_WIN_ERROR_DATA
 ifdef VBOX_WITH_NOCRT_STATIC
  if1of ($(KBUILD_TARGET), win)
-  RuntimeR3_USES  = $(RuntimeBaseR3_USES) VBoxNoCrtAliases
-  RuntimeR3_DEFS += $(filter-out RT_WITHOUT_NOCRT_WRAPPERS,$(RuntimeBaseR3_DEFS)) \
+  RuntimeR3_USES   = $(RuntimeBaseR3_USES) VBoxNoCrtAliases
+  RuntimeR3_DEFS   = $(filter-out RT_WITHOUT_NOCRT_WRAPPERS,$(RuntimeBaseR3_DEFS)) \
         RT_FORCE_NOCRT_WRAPPERS \
         RT_WITH_NOCRT_ALIASES RT_WITH_NOCRT_UNDERSCORE_ALIASES RT_WITH_GENALIAS_NOCRT_ALIASES
@@ -2075 +2081 @@
  endif
 endif
+
 
 #

trunk/src/VBox/Runtime/win/errmsgwin.cpp

@@ -41 +41 @@
 *   Global Variables                                                                                                             *
 *********************************************************************************************************************************/
-#ifdef IPRT_NO_ERROR_DATA
+#if defined(IPRT_NO_ERROR_DATA) || defined(IPRT_NO_WIN_ERROR_DATA)
 /* Cook data just for VINF_SUCCESS so that code below compiles fine. */
 static const char            g_achWinStrTabData[] = { "ERROR_SUCCESS" };