Changeset 96392 in vbox

Timestamp:

Aug 22, 2022 8:01:49 AM (2 years ago)

Author:

vboxsync

Message:

VMM/IEM: Implement addsubps/addsubpd instructions, bugref:9898

Location:

trunk/src/VBox/VMM

Files:

• VMMAll/IEMAllAImpl.asm (modified) (1 diff)
• VMMAll/IEMAllAImplC.cpp (modified) (1 diff)
• VMMAll/IEMAllInstructionsTwoByte0f.cpp.h (modified) (1 diff)
• include/IEMInternal.h (modified) (3 diffs)
• testcase/tstIEMCheckMc.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAllAImpl.asm

@@ -4634 +4634 @@
 IEMIMPL_FP_F2 hsubps, 3
 IEMIMPL_FP_F2 hsubpd, 3
+IEMIMPL_FP_F2 addsubps, 3
+IEMIMPL_FP_F2 addsubpd, 3
+
 
 ;;

trunk/src/VBox/VMM/VMMAll/IEMAllAImplC.cpp

@@ -14975 +14975 @@
 }
 #endif
+
+
+/**
+ * ADDSUBPS
+ */
+#ifdef IEM_WITHOUT_ASSEMBLY
+IEM_DECL_IMPL_DEF(void, iemAImpl_addsubps_u128,(PX86FXSTATE pFpuState, PIEMSSERESULT pResult, PCX86XMMREG puSrc1, PCX86XMMREG puSrc2))
+{
+    RT_NOREF(puSrc1);
+
+    pResult->MXCSR  = iemAImpl_subps_u128_worker(&pResult->uResult.ar32[0], pFpuState->MXCSR, &puSrc1->ar32[0], &puSrc2->ar32[0]);
+    pResult->MXCSR |= iemAImpl_addps_u128_worker(&pResult->uResult.ar32[1], pFpuState->MXCSR, &puSrc1->ar32[1], &puSrc2->ar32[1]);
+    pResult->MXCSR |= iemAImpl_subps_u128_worker(&pResult->uResult.ar32[2], pFpuState->MXCSR, &puSrc1->ar32[2], &puSrc2->ar32[2]);
+    pResult->MXCSR |= iemAImpl_addps_u128_worker(&pResult->uResult.ar32[3], pFpuState->MXCSR, &puSrc1->ar32[3], &puSrc2->ar32[3]);
+}
+#endif
+
+
+/**
+ * ADDSUBPD
+ */
+#ifdef IEM_WITHOUT_ASSEMBLY
+IEM_DECL_IMPL_DEF(void, iemAImpl_addsubpd_u128,(PX86FXSTATE pFpuState, PIEMSSERESULT pResult, PCX86XMMREG puSrc1, PCX86XMMREG puSrc2))
+{
+    RT_NOREF(puSrc1);
+
+    pResult->MXCSR  = iemAImpl_subpd_u128_worker(&pResult->uResult.ar64[0], pFpuState->MXCSR, &puSrc1->ar64[0], &puSrc2->ar64[0]);
+    pResult->MXCSR |= iemAImpl_addpd_u128_worker(&pResult->uResult.ar64[1], pFpuState->MXCSR, &puSrc1->ar64[1], &puSrc2->ar64[1]);
+}
+#endif

trunk/src/VBox/VMM/VMMAll/IEMAllInstructionsTwoByte0f.cpp.h

@@ -10339 +10339 @@
 
 /*  Opcode      0x0f 0xd0 - invalid */
+
+
 /** Opcode 0x66 0x0f 0xd0 - addsubpd Vpd, Wpd */
-FNIEMOP_STUB(iemOp_addsubpd_Vpd_Wpd);
+FNIEMOP_DEF(iemOp_addsubpd_Vpd_Wpd)
+{
+    IEMOP_MNEMONIC2(RM, ADDSUBPD, addsubpd, Vpd, Wpd, DISOPTYPE_HARMLESS, 0);
+    return FNIEMOP_CALL_1(iemOpCommonSse3Fp_FullFull_To_Full, iemAImpl_addsubpd_u128);
+}
+
+
 /*  Opcode 0xf3 0x0f 0xd0 - invalid */
+
+
 /** Opcode 0xf2 0x0f 0xd0 - addsubps Vps, Wps */
-FNIEMOP_STUB(iemOp_addsubps_Vps_Wps);
+FNIEMOP_DEF(iemOp_addsubps_Vps_Wps)
+{
+    IEMOP_MNEMONIC2(RM, ADDSUBPS, addsubps, Vps, Wps, DISOPTYPE_HARMLESS, 0);
+    return FNIEMOP_CALL_1(iemOpCommonSse3Fp_FullFull_To_Full, iemAImpl_addsubps_u128);
+}
+
+
 
 /** Opcode      0x0f 0xd1 - psrlw Pq, Qq */

trunk/src/VBox/VMM/include/IEMInternal.h

@@ -2444 +2444 @@
 FNIEMAIMPLFPSSEF2U128 iemAImpl_sqrtps_u128;
 FNIEMAIMPLFPSSEF2U128 iemAImpl_sqrtpd_u128;
+FNIEMAIMPLFPSSEF2U128 iemAImpl_addsubps_u128;
+FNIEMAIMPLFPSSEF2U128 iemAImpl_addsubpd_u128;
 
 FNIEMAIMPLFPSSEF2U128R32 iemAImpl_addss_u128_r32;
@@ -2480 +2482 @@
 FNIEMAIMPLFPAVXF3U128 iemAImpl_vsqrtps_u128, iemAImpl_vsqrtps_u128_fallback;
 FNIEMAIMPLFPAVXF3U128 iemAImpl_vsqrtpd_u128, iemAImpl_vsqrtpd_u128_fallback;
+FNIEMAIMPLFPAVXF3U128 iemAImpl_vaddsubps_u128, iemAImpl_vaddsubps_u128_fallback;
+FNIEMAIMPLFPAVXF3U128 iemAImpl_vaddsubpd_u128, iemAImpl_vaddsubpd_u128_fallback;
 
 FNIEMAIMPLFPAVXF3U128R32 iemAImpl_vaddss_u128_r32, iemAImpl_vaddss_u128_r32_fallback;
@@ -2512 +2516 @@
 FNIEMAIMPLFPAVXF3U256 iemAImpl_vhsubps_u256, iemAImpl_vhsubps_u256_fallback;
 FNIEMAIMPLFPAVXF3U256 iemAImpl_vhsubpd_u256, iemAImpl_vhsubpd_u256_fallback;
+FNIEMAIMPLFPAVXF3U256 iemAImpl_vhaddsubps_u256, iemAImpl_vhaddsubps_u256_fallback;
+FNIEMAIMPLFPAVXF3U256 iemAImpl_vhaddsubpd_u256, iemAImpl_vhaddsubpd_u256_fallback;
 /** @} */
 

trunk/src/VBox/VMM/testcase/tstIEMCheckMc.cpp

@@ -480 +480 @@
 #define iemAImpl_sqrtps_u128            NULL
 #define iemAImpl_sqrtpd_u128            NULL
+#define iemAImpl_addsubps_u128          NULL
+#define iemAImpl_addsubpd_u128          NULL
 
 #define iemAImpl_addss_u128_r32         NULL