Changeset 96519 in vbox

Timestamp:

Aug 26, 2022 12:20:35 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

153384

Message:

IPRT/thread-posix.cpp: Try initialize g_SelfKey to a non-valid value to prevent accidental use of someone else's data. bugref:10261

File:

• trunk/src/VBox/Runtime/r3/posix/thread-posix.cpp (modified) (2 diffs)

trunk/src/VBox/Runtime/r3/posix/thread-posix.cpp

@@ -41 +41 @@
 #define LOG_GROUP RTLOGGROUP_THREAD
 #include <errno.h>
+#include <limits.h>
 #include <pthread.h>
 #include <signal.h>
@@ -99 +100 @@
 *   Global Variables                                                                                                             *
 *********************************************************************************************************************************/
-/** The pthread key in which we store the pointer to our own PRTTHREAD structure. */
-static pthread_key_t    g_SelfKey;
+/** The pthread key in which we store the pointer to our own PRTTHREAD structure.
+ * @note There is a defined NIL value here, nor can we really assume this is an
+ *       integer.  However, zero is a valid key on Linux, so we get into trouble
+ *       if we accidentally use it uninitialized.
+ *
+ *       So, we ASSUME it's a integer value and the valid range is in approx 0
+ *       to PTHREAD_KEYS_MAX.  Solaris has at least one negative value (-1)
+ *       defined.  Thus, we go for 16 MAX values below zero and keep our fingers
+ *       cross that it will always be an invalid key value everywhere...
+ *
+ *       See also NIL_RTTLS, which is -1.
+ */
+static pthread_key_t    g_SelfKey = (pthread_key_t)(-PTHREAD_KEYS_MAX * 16);
 #ifdef RTTHREAD_POSIX_WITH_POKE
 /** The signal we use for poking threads.