testmanager

Timestamp:

Sep 2, 2022 9:59:17 AM (2 years ago)

Author:

vboxsync

Message:

Validation Kit/testmanager/batch: Added a safe variant for replacing files in maintain_archived_testsets.py [pylint]. bugref:8733

File:

trunk/src/VBox/ValidationKit/testmanager/batch/maintain_archived_testsets.py

-              r96575
+              r96576
         """
+        fRc = True;
         # Rename the destination file first (if any).
         sDstFileTmp = None;
 …
                 if not fForce:
                     print('Replace file: Warning: Temporary destination file "%s" already exists, skipping' % (sDstFileTmp,));
                     return False;
+                    fRc = False;
                 else:
                     try:
 …
                     except Exception as e:
                         print('Replace file: Error deleting old temporary destination file "%s": %s' % (sDstFileTmp, e));
                         return False;
+                        fRc = False;
             try:
                 if not fDryRun:
 …
                 print('Replace file: Error moving old destination file "%s" to temporary file "%s": %s' \
                       % (sDstFile, sDstFileTmp, e));
+                return False;
+        fRc = True;
+                fRc = False;
+        if not fRc:
+            return False;
         try:

Note: See TracChangeset for help on using the changeset viewer.