Changeset 96586 in vbox for trunk/src/VBox/Runtime/r3/win

Timestamp:

Sep 3, 2022 2:35:25 AM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

153463

Message:

IPRT/nocrt: The pcbWritten parameter of WriteFile must always be specified, as it is not optional on older windows versions (NT3.1 at least). bugref:10261

Location:

trunk/src/VBox/Runtime/r3/win

Files:

• nocrt-RTLogWriteStdErr-win.cpp (modified) (1 diff)
• nocrt-RTLogWriteStdOut-win.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/r3/win/nocrt-RTLogWriteStdErr-win.cpp

@@ -49 +49 @@
     HANDLE hStdErr = GetStdHandle(STD_ERROR_HANDLE);
     if (hStdErr != NULL && hStdErr != INVALID_HANDLE_VALUE)
-        WriteFile(hStdErr, pch, (DWORD)cb, NULL, NULL); /** @todo do we need to translate \\n to \\r\\n? */
+    {
+        DWORD cbIgn; /* NT3.1 requires the return size parameter. */
+        WriteFile(hStdErr, pch, (DWORD)cb, &cbIgn, NULL); /** @todo do we need to translate \\n to \\r\\n? */
+    }
 }
 RT_EXPORT_SYMBOL(RTLogWriteStdErr);

trunk/src/VBox/Runtime/r3/win/nocrt-RTLogWriteStdOut-win.cpp

@@ -50 +50 @@
     HANDLE hStdErr = GetStdHandle(STD_OUTPUT_HANDLE);
     if (hStdErr != NULL && hStdErr != INVALID_HANDLE_VALUE)
-        WriteFile(hStdErr, pch, (DWORD)cb, NULL, NULL); /** @todo do we need to translate \\n to \\r\\n? */
+    {
+        DWORD cbIgn; /* NT3.1 requires the return size parameter. */
+        WriteFile(hStdErr, pch, (DWORD)cb, &cbIgn, NULL); /** @todo do we need to translate \\n to \\r\\n? */
+    }
 }
 RT_EXPORT_SYMBOL(RTLogWriteStdOut);