Changeset 96588 in vbox for trunk/src/VBox/Runtime/r3/win

Timestamp:

Sep 3, 2022 2:40:14 AM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

153465

Message:

IPRT/nocrt: Added workaround for NT3.1 not knowing about Misc.VirtualSize and not clearing uninitialized data at the end of sections. bugref:10261

Location:

trunk/src/VBox/Runtime/r3/win

Files:

• nocrt-startup-common-win.cpp (modified) (1 diff)
• nocrt-startup-dll-win.cpp (modified) (1 diff)
• nocrt-startup-exe-win.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/r3/win/nocrt-startup-common-win.cpp

@@ -55 +55 @@
 #include "internal/process.h"
 
+
+#ifdef RT_ARCH_X86
+/**
+ * NT 3.1 does not know about the IMAGE_SECTION_HEADER::Misc.VirtualSize field
+ * and will therefore not handle merging initialized and uninitialized data into
+ * the same section.
+ *
+ * We work around this by manually zeroing the uninitialized data before any
+ * other code has been executed.
+ */
+void rtVccWinInitBssOnNt3(void *pvImageBase)
+{
+    /* We are called really early on, so we must figure out the NT version
+       on our own.  It doesn't have to be all that accurate, though, as only
+       NT 3.10 is affected (3.50 isn't). */
+    DWORD const dwRawVer  = GetVersion();
+    DWORD const uMajorVer = RT_BYTE1(dwRawVer);
+    DWORD const uMinorVer = RT_BYTE2(dwRawVer);
+    if (uMajorVer != 3 || uMinorVer >= 50)
+        return;
+
+    /*
+     * Locate the NT headers.
+     */
+    PIMAGE_NT_HEADERS   pNtHdrs;
+    PIMAGE_DOS_HEADER   pDosHdr = (PIMAGE_DOS_HEADER)pvImageBase;
+    if (pDosHdr->e_magic == IMAGE_DOS_SIGNATURE)
+        pNtHdrs = (PIMAGE_NT_HEADERS)((uintptr_t)pvImageBase + pDosHdr->e_lfanew);
+    else
+        pNtHdrs = (PIMAGE_NT_HEADERS)pvImageBase;
+    if (pNtHdrs->Signature == IMAGE_NT_SIGNATURE)
+    {
+        /*
+         * Locate the section table and walk thru it, memsetting anything that
+         * wasn't loaded from the file.
+         */
+        PIMAGE_SECTION_HEADER paSHdrs = (PIMAGE_SECTION_HEADER)(  (uintptr_t)&pNtHdrs->OptionalHeader
+                                                                + pNtHdrs->FileHeader.SizeOfOptionalHeader);
+        uint32_t const        cSections = pNtHdrs->FileHeader.NumberOfSections;
+        for (uint32_t i = 0; i < cSections; i++)
+        {
+            if (paSHdrs[i].Misc.VirtualSize > paSHdrs[i].SizeOfRawData)
+            {
+                /* ASSUMES VirtualAddress is still an RVAs */
+                uint8_t       *pbToZero = (uint8_t *)pvImageBase + paSHdrs[i].VirtualAddress + paSHdrs[i].SizeOfRawData;
+                uint32_t const cbToZero = paSHdrs[i].Misc.VirtualSize - paSHdrs[i].SizeOfRawData;
+
+# if 0 /* very very crude debugging */
+                const char *pszHex = "0123456789abcdef";
+                char szMsg[128];
+                char *psz = szMsg;
+                *psz++ = 'd'; *psz++ = 'b'; *psz++ = 'g'; *psz++ = ':'; *psz++ = ' ';
+                for (uint32_t q = 0, u = i; q < 8; q++, u >>= 4)
+                    psz[7 - q] = pszHex[u & 0xf];
+                psz += 8;
+                *psz++ = ':';
+                *psz++ = ' ';
+                for (uint32_t q = 0, u = (uint32_t)pbToZero; q < 8; q++, u >>= 4)
+                    psz[7 - q] = pszHex[u & 0xf];
+                psz += 8;
+                *psz++ = ' ';
+                *psz++ = 'L';
+                *psz++ = 'B';
+                *psz++ = ' ';
+                for (uint32_t q = 0, u = cbToZero; q < 8; q++, u >>= 4)
+                    psz[7 - q] = pszHex[u & 0xf];
+                psz += 8;
+                *psz++ = ' ';
+                for (uint32_t q = 0; q < 8; q++)
+                    *psz++ = paSHdrs[i].Name[q] ? paSHdrs[i].Name[q] : ' ';
+                *psz++ = ' '; *psz++ = '/'; *psz++ = ' '; *psz++ = 'v'; *psz++ = 'e'; *psz++ = 'r'; *psz++ = ' ';
+                *psz++ = pszHex[(uMajorVer >> 4) & 0xf];
+                *psz++ = pszHex[uMajorVer & 0xf];
+                *psz++ = '.';
+                *psz++ = pszHex[(uMinorVer >> 4) & 0xf];
+                *psz++ = pszHex[uMinorVer & 0xf];
+                *psz++ = '\r'; *psz++ = '\n';
+                *psz   = '\0';
+                DWORD cbIgn;
+                HANDLE hOut = RTNtCurrentPeb()->ProcessParameters->StandardOutput;
+                if (hOut == NULL || hOut == INVALID_HANDLE_VALUE)
+                    hOut = RTNtCurrentPeb()->ProcessParameters->StandardError;
+                if (hOut == NULL || hOut == INVALID_HANDLE_VALUE)
+                    hOut = RTNtCurrentPeb()->ProcessParameters->ConsoleHandle;
+                if (hOut == NULL || hOut == INVALID_HANDLE_VALUE)
+                    hOut = GetStdHandle(STD_OUTPUT_HANDLE);
+                WriteFile(hOut, szMsg, psz - szMsg, &cbIgn, NULL);
+# endif
+
+                if (paSHdrs[i].Characteristics & IMAGE_SCN_MEM_WRITE)
+                    memset(pbToZero, 0, cbToZero);
+                else
+                {
+                    /* The section is not writable, so temporarily make it writable. */
+                    PVOID pvAligned = pbToZero - ((uintptr_t)pbToZero & PAGE_OFFSET_MASK);
+                    ULONG cbAligned = RT_ALIGN_32(cbToZero + ((uintptr_t)pbToZero & PAGE_OFFSET_MASK), PAGE_SIZE);
+                    ULONG fNewProt  = paSHdrs[i].Characteristics & IMAGE_SCN_MEM_EXECUTE
+                                    ? PAGE_EXECUTE_READWRITE : PAGE_READWRITE;
+                    ULONG fOldProt  = fNewProt;
+                    NTSTATUS rcNt = NtProtectVirtualMemory(NtCurrentProcess(), &pvAligned, &cbAligned, fNewProt, &fOldProt);
+                    if (NT_SUCCESS(rcNt))
+                    {
+                        memset(pbToZero, 0, cbToZero);
+
+                        rcNt = NtProtectVirtualMemory(NtCurrentProcess(), &pvAligned, &cbAligned, fOldProt, &fNewProt);
+                    }
+                    else
+                        RT_BREAKPOINT();
+                }
+            }
+        }
+    }
+    else
+        RT_BREAKPOINT();
+}
+#endif
 
 

trunk/src/VBox/Runtime/r3/win/nocrt-startup-dll-win.cpp

@@ -147 +147 @@
     {
         case DLL_PROCESS_ATTACH:
+#ifdef RT_ARCH_X86
+            rtVccWinInitBssOnNt3((PVOID)hInstance);
+#endif
             rtVccInitSecurityCookie(); /* This function must be minimal because of this! */
             return rtVccDllMainProcessAttach(hInstance, pvReserved);

trunk/src/VBox/Runtime/r3/win/nocrt-startup-exe-win.cpp

@@ -92 +92 @@
      */
 #ifdef IPRT_NO_CRT
+# ifdef RT_ARCH_X86
+    rtVccWinInitBssOnNt3(pPeb->ImageBaseAddress);
+# endif
     rtVccInitSecurityCookie();
 #else