Changeset 96810 in vbox for trunk/src/VBox/Runtime

Timestamp:

Sep 21, 2022 12:53:43 PM (2 years ago)

Author:

vboxsync

Message:

IPRT/log.cpp: Make sure we don't recurse forever via rtLogDefaultInstanceCreateNew. bugref:10261

File:

• trunk/src/VBox/Runtime/common/log/log.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/log/log.cpp

@@ -465 +465 @@
 DECL_NO_INLINE(static, PRTLOGGER) rtLogDefaultInstanceCreateNew(void)
 {
-    PRTLOGGER pRet = RTLogDefaultInit();
-    if (pRet)
-    {
-        bool fRc = ASMAtomicCmpXchgPtr(&g_pLogger, pRet, NULL);
-        if (!fRc)
-        {
-            RTLogDestroy(pRet);
-            pRet = g_pLogger;
-        }
+    PRTLOGGER pRet = NULL;
+
+    /*
+     * It's soo easy to end up in a infinite recursion here when enabling 'all'
+     * the logging groups. So, only allow one thread to instantiate the default
+     * logger, muting other attempts at logging while it's being created.
+     */
+    static volatile bool s_fCreating = false;
+    if (ASMAtomicCmpXchgBool(&s_fCreating, true, false))
+    {
+        pRet = RTLogDefaultInit();
+        if (pRet)
+        {
+            bool fRc = ASMAtomicCmpXchgPtr(&g_pLogger, pRet, NULL);
+            if (!fRc)
+            {
+                RTLogDestroy(pRet);
+                pRet = g_pLogger;
+            }
+        }
+        ASMAtomicWriteBool(&s_fCreating, true);
     }
     return pRet;