Changeset 96850 in vbox

Timestamp:

Sep 26, 2022 4:39:32 AM (2 years ago)

Author:

vboxsync

Message:

Main/tstOVF: Use RTFileExists to test for the existance of a file, on the right file path, mind. Don't use TABs or leave trailing whitepace on lines.

File:

• trunk/src/VBox/Main/testcase/tstOVF.cpp (modified) (2 diffs)

trunk/src/VBox/Main/testcase/tstOVF.cpp

@@ -232 +232 @@
                     pcszType = "sound";
                 break;
-                                
-                                case VirtualSystemDescriptionType_SettingsFile:
+
+                case VirtualSystemDescriptionType_SettingsFile:
                     pcszType = "settings";
                 break;
-                                
-                                case VirtualSystemDescriptionType_BaseFolder:
+
+                case VirtualSystemDescriptionType_BaseFolder:
                     pcszType = "basefolder";
                 break;
-                                
-                                case VirtualSystemDescriptionType_PrimaryGroup:
+
+                case VirtualSystemDescriptionType_PrimaryGroup:
                     pcszType = "primarygroup";
                 break;
@@ -294 +294 @@
 {
     char szSrc[RTPATH_MAX];
-    char szDst[RTPATH_MAX];
     RTPathExecDir(szSrc, sizeof(szSrc));
     RTPathAppend(szSrc, sizeof(szSrc), "ovf-testcases/ovf-dummy.vmdk");
+
+    char szDst[RTPATH_MAX];
     RTPathExecDir(szDst, sizeof(szDst));
     RTPathAppend(szDst, sizeof(szDst), pcszDest);
     RTPrintf("%s: copying ovf-dummy.vmdk to \"%s\"...\n", pcszPrefix, pcszDest);
 
-        if (FILE *file = fopen(pcszDest, "r"))
-        {
-                fclose(file);
-                RTFileDelete(pcszDest);
-        }
+    /* Delete the destination file if it exists or RTFileCopy will fail. */
+    if (RTFileExists(szDst))
+    {
+        RTPrintf("Deleting file %s...\n", szDst);
+        RTFileDelete(szDst);
+    }
 
     int vrc = RTFileCopy(szSrc, szDst);