Changeset 96860 in vbox for trunk

Timestamp:

Sep 26, 2022 10:44:31 AM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

153766

Message:

IEM: The CMP instruction must not zero out the high half of 64-bit GPRs.

Location:

trunk/src/VBox/VMM/VMMAll

Files:

• IEMAllInstructionsInterpretOnly.cpp (modified) (4 diffs)
• IEMAllInstructionsOneByte.cpp.h (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllInstructionsInterpretOnly.cpp

@@ -1034 +1034 @@
                 IEM_MC_CALL_VOID_AIMPL_3(pImpl->pfnNormalU32, pu32Dst, u32Src, pEFlags);
 
-                if (pImpl != &g_iemAImpl_test)
+                if ((pImpl != &g_iemAImpl_test) && (pImpl != &g_iemAImpl_cmp))
                     IEM_MC_CLEAR_HIGH_GREG_U64_BY_REF(pu32Dst);
                 IEM_MC_ADVANCE_RIP();
@@ -1241 +1241 @@
                 IEM_MC_CALL_VOID_AIMPL_3(pImpl->pfnNormalU32, pu32Dst, u32Src, pEFlags);
 
-                IEM_MC_CLEAR_HIGH_GREG_U64_BY_REF(pu32Dst);
+                if (pImpl != &g_iemAImpl_cmp)   /* Not used with TEST. */
+                    IEM_MC_CLEAR_HIGH_GREG_U64_BY_REF(pu32Dst);
                 IEM_MC_ADVANCE_RIP();
                 IEM_MC_END();
@@ -1301 +1302 @@
                 IEM_MC_CALL_VOID_AIMPL_3(pImpl->pfnNormalU32, pu32Dst, u32Src, pEFlags);
 
-                IEM_MC_CLEAR_HIGH_GREG_U64_BY_REF(pu32Dst);
+                if (pImpl != &g_iemAImpl_cmp)
+                    IEM_MC_CLEAR_HIGH_GREG_U64_BY_REF(pu32Dst);
                 IEM_MC_ADVANCE_RIP();
                 IEM_MC_END();
@@ -1398 +1400 @@
             IEM_MC_CALL_VOID_AIMPL_3(pImpl->pfnNormalU32, pu32Dst, u32Src, pEFlags);
 
-            if (pImpl != &g_iemAImpl_test)
+            if ((pImpl != &g_iemAImpl_test) && (pImpl != &g_iemAImpl_cmp))
                 IEM_MC_CLEAR_HIGH_GREG_U64_BY_REF(pu32Dst);
             IEM_MC_ADVANCE_RIP();

trunk/src/VBox/VMM/VMMAll/IEMAllInstructionsOneByte.cpp.h

@@ -3285 +3285 @@
                 IEM_MC_REF_EFLAGS(pEFlags);
                 IEM_MC_CALL_VOID_AIMPL_3(pImpl->pfnNormalU32, pu32Dst, u32Src, pEFlags);
-                IEM_MC_CLEAR_HIGH_GREG_U64_BY_REF(pu32Dst);
+                if (pImpl != &g_iemAImpl_cmp)   /* Not used with TEST. */
+                    IEM_MC_CLEAR_HIGH_GREG_U64_BY_REF(pu32Dst);
 
                 IEM_MC_ADVANCE_RIP();
@@ -3454 +3455 @@
                 IEM_MC_REF_EFLAGS(pEFlags);
                 IEM_MC_CALL_VOID_AIMPL_3(pImpl->pfnNormalU32, pu32Dst, u32Src, pEFlags);
-                IEM_MC_CLEAR_HIGH_GREG_U64_BY_REF(pu32Dst);
+                if (pImpl != &g_iemAImpl_cmp)   /* Not used with TEST. */
+                    IEM_MC_CLEAR_HIGH_GREG_U64_BY_REF(pu32Dst);
 
                 IEM_MC_ADVANCE_RIP();