Changeset 96908 in vbox for trunk

Timestamp:

Sep 27, 2022 10:18:39 PM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

153818

Message:

Main/MouseImpl: My 0.02$ and some cleanups. bugref:10285

File:

• trunk/src/VBox/Main/src-client/MouseImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/src-client/MouseImpl.cpp

@@ -661 +661 @@
 {
     HRESULT hrc;
-    /** If we are using the VMMDev to report absolute position but without
-     * VMMDev IRQ support then we need to send a small "jiggle" to the emulated
-     * relative mouse device to alert the guest to changes. */
-    LONG cJiggle = 0;
-
     if (i_vmmdevCanAbs())
     {
+        /*
+         * If we are using the VMMDev to report absolute position but without
+         * VMMDev IRQ support then we need to send a small "jiggle" to the
+         * emulated relative mouse device to alert the guest to changes.
+         */
+        LONG cJiggle = 0;
+
         /*
          * Send the absolute mouse position to the VMM device.
@@ -677 +679 @@
         }
 
-        /* Since VMMDev does not deal with mouse buttons state, also
+        /*
+         * Since VMMDev does not deal with mouse buttons state, also
          * send relative or absolute pointing event to emulated mouse
          * device once it supports it.
@@ -687 +690 @@
          * USB MT TouchScreen and TouchPad.
          *
-         * IMPORTANT: Avoid sending relative event to devices which can
-         * do both relative and absolute pointing since it will result
-         * in misbehavior. */
+         * IMPORTANT: Do not send relative event to devices which can
+         * do both relative and absolute pointing since it may result
+         * in unexpected behaviour.
+         *
+         * r=bird: Not entirely convinced this is a correct fix.
+         *
+         * See @bugref{10285} for background and more theories.
+         */
         if (!i_deviceCanAbs())
             hrc = i_reportRelEventToMouseDev(cJiggle, 0, dz, dw, fButtons);