Changeset 97020 in vbox

Timestamp:

Oct 6, 2022 3:27:21 AM (2 years ago)

Author:

vboxsync

Message:

VMM/IEM: Nested VMX: bugref:10092 This workaround/hack is no longer required with the fix from r153881/r153906 and consequent removal of PGM_WITH_NESTED_APIC_ACCESS_PAGE.

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllCImplVmxInstr.cpp (modified) (1 diff)

trunk/src/VBox/VMM/VMMAll/IEMAllCImplVmxInstr.cpp

@@ -9935 +9935 @@
 
             /*
-             * WARNING: HACK AHEAD!
-             * The below is a the old behavior which composes an incomplete APIC-access VM-exit.
-             * This will result in the inner hypervisor emulating the access since it lacks info
-             * for a linear read/write accesses. Unfortunately, this is required till the
-             * virtual VMX APIC-access page mapping using PGM_WITH_NESTED_APIC_ACCESS_PAGE is
-             * fixed properly.
-             */
-            if (HmExitAux.Vmx.uReason == VMX_EXIT_EPT_MISCONFIG)
-            {
-                LogFlowFunc(("Raising APIC-access VM-exit as phys access from #PF handler at offset %#x\n", offAccess));
-                VMXVEXITINFO const ExitInfo = VMXVEXITINFO_INIT_WITH_QUALIFIER(VMX_EXIT_APIC_ACCESS,
-                                                                                 RT_BF_MAKE(VMX_BF_EXIT_QUAL_APIC_ACCESS_OFFSET,
-                                                                                            offAccess)
-                                                                               | RT_BF_MAKE(VMX_BF_EXIT_QUAL_APIC_ACCESS_TYPE,
-                                                                                            VMXAPICACCESS_PHYSICAL_INSTR));
-                VMXVEXITEVENTINFO const ExitEventInfo = VMXVEXITEVENTINFO_INIT_ONLY_IDT(HmExitAux.Vmx.uIdtVectoringInfo,
-                                                                                        HmExitAux.Vmx.uIdtVectoringErrCode);
-                VBOXSTRICTRC const      rcStrict      = iemVmxVmexitApicAccessWithInfo(pVCpu, &ExitInfo, &ExitEventInfo);
-                return iemExecStatusCodeFiddling(pVCpu, rcStrict);
-            }
-
-            /*
              * Verify the VM-exit reason must be an EPT violation.
              * Other accesses should go through the other handler (iemVmxApicAccessPageHandler).