Changeset 97260 in vbox for trunk/src/VBox/Frontends/VBoxManage

Timestamp:

Oct 20, 2022 11:02:43 PM (3 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

154246

Message:

Frontends/VBoxManage+Storage/VMDK+doc/manual: 'VBoxManage createmedium
disk --Variant Rawdisk ...' neglects to use the calculated raw disk size
but instead uses the passed in value which is zero (unless --size or
--sizebyte has been specified) when creating the VMDK image and also
forgets to update the physical disk geometry (PCHS) for the VMDK image.
bugref:9224 ticketref:21125

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageDisk.cpp (modified) (3 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageDisk.cpp

@@ -486 +486 @@
             }
         }
+        if ((enmMediumVariant & MediumVariant_VmdkRawDisk) && strcmp(format, "VMDK"))
+            return errorSyntax(Disk::tr("Variant 'Rawdisk' requires '--format=VMDK'"));
     }
     else
@@ -491 +493 @@
         if (   !filename
             || !*filename)
-            return errorSyntax(Disk::tr("Parameters --filename is required"));
+            return errorSyntax(Disk::tr("Parameter --filename is required"));
         size = 0;
         if (cmd != CMD_DISK)
@@ -596 +598 @@
                 if (!fPropertyFound)
                     return RTMsgErrorExit(RTEXITCODE_FAILURE,
-                                          Disk::tr("The %s is not found in the property list of the requested medium format."),
-                                          pszKey);
+                                          Disk::tr("Property '%s' was not found in the list of medium properties for the requested medium format (%s)."),
+                                          pszKey, format);
                 if (!fBinary)
                     CHECK_ERROR2I_RET(pMedium, SetProperty(Bstr(pszKey).raw(), Bstr(it->m_pszValue).raw()),