Changeset 97673 in vbox for trunk/src/VBox/ValidationKit/testmanager/webui

Timestamp:

Nov 24, 2022 11:46:15 AM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

154728

Message:

Validation Kit: Fixed lots of warnings, based on pylint 2.12.2.

Location:

trunk/src/VBox/ValidationKit/testmanager/webui

Files:

• wuiadminglobalrsrc.py (modified) (1 diff)
• wuiadmintestbox.py (modified) (1 diff)
• wuibase.py (modified) (3 diffs)
• wuicontentbase.py (modified) (3 diffs)
• wuigraphwiz.py (modified) (1 diff)
• wuihlpform.py (modified) (1 diff)
• wuihlpgraphmatplotlib.py (modified) (2 diffs)
• wuireport.py (modified) (1 diff)
• wuitestresult.py (modified) (1 diff)

trunk/src/VBox/ValidationKit/testmanager/webui/wuiadminglobalrsrc.py

@@ -77 +77 @@
         oForm = WuiHlpForm('globalresourceform',
                            sFormActionUrl,
-                           dErrors if dErrors is not None else dict())
+                           dErrors if dErrors is not None else {})
 
         if sAction == WuiAdmin.ksActionGlobalRsrcAdd:

trunk/src/VBox/ValidationKit/testmanager/webui/wuiadmintestbox.py

@@ -393 +393 @@
             sVer1 = sOsVersion;
             sVer2 = None;
-            if oEntry.sOs == 'linux' or oEntry.sOs == 'darwin':
+            if oEntry.sOs in ('linux', 'darwin'):
                 iSep = sOsVersion.find(' / ');
                 if iSep > 0:

trunk/src/VBox/ValidationKit/testmanager/webui/wuibase.py

@@ -145 +145 @@
         self._fDbgSqlTrace      = False;
         self._fDbgSqlExplain    = False;
-        self._dDbgParams        = dict();
+        self._dDbgParams        = {};
         for sKey, sValue in oSrvGlue.getParameters().items():
             if sKey in self.kasDbgParams:
@@ -322 +322 @@
         # Load the template.
         #
-        with open(os.path.join(self._oSrvGlue.pathTmWebUI(), self._sTemplate)) as oFile:
+        with open(os.path.join(self._oSrvGlue.pathTmWebUI(), self._sTemplate)) as oFile: # pylint: disable=unspecified-encoding
             sTmpl = oFile.read();
 
@@ -592 +592 @@
             aoListOfTestCases.append(oListEntryTestCase)
 
-        if aoListOfTestCases == []:
+        if not aoListOfTestCases:
             if asDefaults is None:
                 raise WuiException('%s is missing parameters: "%s"' % (self._sAction, sName))

trunk/src/VBox/ValidationKit/testmanager/webui/wuicontentbase.py

@@ -190 +190 @@
         from testmanager.webui.wuiadmin import WuiAdmin;
         if not dParams:
-            dParams = dict();
+            dParams = {};
         else:
             dParams = dict(dParams);
@@ -205 +205 @@
     def __init__(self, sName, sAction, dParams = None, sConfirm = None, sTitle = None, sFragmentId = None, fBracketed = True):
         if not dParams:
-            dParams = dict();
+            dParams = {};
         else:
             dParams = dict(dParams);
@@ -757 +757 @@
         oForm = WuiHlpForm(self._sId,
                            '?' + webutils.encodeUrlParams({WuiDispatcherBase.ksParamAction: self._sSubmitAction}),
-                           dErrors if dErrors is not None else dict(),
+                           dErrors if dErrors is not None else {},
                            fReadOnly = self._sMode == self.ksMode_Show);
 

trunk/src/VBox/ValidationKit/testmanager/webui/wuigraphwiz.py

@@ -220 +220 @@
 
         # Split on unit.
-        dUnitSeries = dict();
+        dUnitSeries = {};
         for oSeries in aoSeries:
             if oSeries.iUnit not in dUnitSeries:

trunk/src/VBox/ValidationKit/testmanager/webui/wuihlpform.py

@@ -69 +69 @@
         self._fFinalized = False;
         self._fReadOnly  = fReadOnly;
-        self._dErrors    = dErrors if dErrors is not None else dict();
+        self._dErrors    = dErrors if dErrors is not None else {};
 
         if sOnSubmit == self.ksOnSubmit_AddReturnToFieldWithCurrentUrl:

trunk/src/VBox/ValidationKit/testmanager/webui/wuihlpgraphmatplotlib.py

@@ -127 +127 @@
         # Extract/structure the required data.
         #
-        aoSeries = list();
+        aoSeries = [];
         for j in range(len(aoTable[1].aoValues)):
-            aoSeries.append(list());
-        asNames  = list();
+            aoSeries.append([]);
+        asNames  = [];
         oXRange  = numpy_arange(self._oData.getGroupCount());
         fpMin = self.fpMin;
@@ -156 +156 @@
         oSubPlot = oFigure.add_subplot(1, 1, 1);
 
-        aoBars = list();
+        aoBars = [];
         for i, _ in enumerate(aoSeries):
             sColor = self.calcSeriesColor(i);

trunk/src/VBox/ValidationKit/testmanager/webui/wuireport.py

@@ -88 +88 @@
         # Additional URL parameters for reports:
         from testmanager.webui.wuimain import WuiMain;
-        self._dExtraParams  = ReportFilter().strainParameters(dict() if oDisp is None else oDisp.getParameters(),
+        self._dExtraParams  = ReportFilter().strainParameters({} if oDisp is None else oDisp.getParameters(),
                                                               (WuiMain.ksParamReportPeriods,
                                                                WuiMain.ksParamReportPeriodInHours,

trunk/src/VBox/ValidationKit/testmanager/webui/wuitestresult.py

@@ -77 +77 @@
     def __init__(self, sGroupedBy, idGroupMember, sName = WuiContentBase.ksShortTestResultsLink,
                  dExtraParams = None, fBracketed = False):
-        dParams = dict(dExtraParams) if dExtraParams else dict();
+        dParams = dict(dExtraParams) if dExtraParams else {};
         dParams[WuiMain.ksParamAction] = sGroupedBy;
         dParams[WuiMain.ksParamGroupMemberId] = idGroupMember;