Changeset 97738 in vbox for trunk/src/VBox/Additions/x11

Timestamp:

Dec 5, 2022 8:17:08 AM (2 years ago)

Author:

vboxsync

Message:

DnD/VBoxClient: Check for a potentially valid window handle in DragInstance::wndX11GetNameA() before calling the X server.

File:

• trunk/src/VBox/Additions/x11/VBoxClient/draganddrop.cpp (modified) (2 diffs)

trunk/src/VBox/Additions/x11/VBoxClient/draganddrop.cpp

@@ -2814 +2814 @@
  *
  * @returns Pointer to the allocated window name.
+ * @retval  NULL on allocation failure.
+ * @retval  "<No name>" if window name was not found / invalid window handle.
  * @param   wndThis                 Window to retrieve name for.
- *
- * @remark If the window title is not available, the text
- *         "<No name>" will be returned.
  */
 char *DragInstance::wndX11GetNameA(Window wndThis) const
@@ -2824 +2823 @@
 
     XTextProperty propName;
-    if (XGetWMName(m_pDisplay, wndThis, &propName))
+    if (   wndThis != None
+        && XGetWMName(m_pDisplay, wndThis, &propName))
     {
         if (propName.value)