Changeset 97743 in vbox for trunk/src/VBox/Additions

Timestamp:

Dec 5, 2022 8:26:00 PM (2 years ago)

Author:

vboxsync

Message:

VBoxService/VBoxServiceVMInfo: Addressed some @todos.

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxServiceVMInfo.cpp (modified) (1 diff)

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceVMInfo.cpp

@@ -434 +434 @@
     if (pszDomain)
     {
-/** @todo r=bird: RTStrAPrintf returns -1, not zero on failure!   */
-        if (!RTStrAPrintf(&pszName, "%s%s@%s/%s", g_pszPropCacheValUser, pszUser, pszDomain, pszKey))
+        if (RTStrAPrintf(&pszName, "%s%s@%s/%s", g_pszPropCacheValUser, pszUser, pszDomain, pszKey) < 0)
             rc = VERR_NO_MEMORY;
     }
     else
     {
-/** @todo r=bird: RTStrAPrintf returns -1, not zero on failure! You got it
- *        right 5 lines further down... */
-        if (!RTStrAPrintf(&pszName, "%s%s/%s", g_pszPropCacheValUser, pszUser, pszKey))
+        if (RTStrAPrintf(&pszName, "%s%s/%s", g_pszPropCacheValUser, pszUser, pszKey) < 0)
             rc = VERR_NO_MEMORY;
     }