Changeset 97774 in vbox for trunk

Timestamp:

Dec 12, 2022 11:13:41 AM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

154842

Message:

Validation Kit: Don't report an actual error when handling core dumps on Solaris hosts fail due to a not available / online coreadm.

File:

• trunk/src/VBox/ValidationKit/testdriver/base.py (modified) (1 diff)

trunk/src/VBox/ValidationKit/testdriver/base.py

@@ -721 +721 @@
             if sKindCrashDump is not None: # Enable.
                 sCorePath = getDirEnv('TESTBOX_PATH_SCRATCH', sAlternative = '/var/cores', fTryCreate = False);
-                utils.sudoProcessOutputChecked([ 'coreadm', '-e', 'global', '-e', 'global-setid', \
-                                                 '-e', 'process', '-e', 'proc-setid', \
-                                                 '-g', os.path.join(sCorePath, '%f.%p.core')]);
+                (iExitCode, _, sErr) = utils.processOutputUnchecked([ 'coreadm', '-e', 'global', '-e', 'global-setid', \
+                                                                      '-e', 'process', '-e', 'proc-setid', \
+                                                                      '-g', os.path.join(sCorePath, '%f.%p.core')]);
             else: # Disable.
-                utils.sudoProcessOutputChecked([ 'coreadm', \
-                                                 '-d', 'global', '-d', 'global-setid', '-d', 'process', '-d', 'proc-setid' ]);
+                (iExitCode, _, sErr) = utils.processOutputUnchecked([ 'coreadm', \
+                                                                      '-d', 'global', '-d', 'global-setid', \
+                                                                      '-d', 'process', '-d', 'proc-setid' ]);
+            if iExitCode != 0: # Don't report an actual error, just log this.
+                reporter.log('%s coreadm failed: %s' % ('Enabling' if sKindCrashDump else 'Disabling', sErr));
 
         if sKindCrashDump is not None: