Changeset 97789 in vbox for trunk/src/VBox/HostServices/DragAndDrop

Timestamp:

Dec 12, 2022 6:43:46 PM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

154860

Message:

DnD: Simplified / untangled reset handling:

• Don't implicitly reset the DnD state with the GuestDnDSendCtx / GuestDnDRecvCtx classes; that can cause side effects.
• Don't reset GuestDnDTargets state before sending data to the guest via GuestDnDTarget::sendData().
• Don't reset the DnD state within GuestDnDState::setProgress() anymore. This needs to be done explicitly by the caller waiting for the progress.
• Make sure to also clear the DnD state's callback map within GuestDnDState::reset().
• Implemented a default guest callback, which gets invoked when no other (registered) guest callbacks are in place (anymore).
• Return VERR_CANCELLED to VBoxTray / VBoxClient clients when there was a reset or the current operation was aborted.
• Release (2) log what has been reset.
• Implement reference counting for internal DnD messages within the host service; this should help wrt races between peeking for new client messages and actual retrieving those messages.

[build fix]

File:

• trunk/src/VBox/HostServices/DragAndDrop/VBoxDragAndDropSvc.cpp (modified) (1 diff)

trunk/src/VBox/HostServices/DragAndDrop/VBoxDragAndDropSvc.cpp

@@ -1017 +1017 @@
                             {
                                 /* Host indicated that the current operation was cancelled. Tell the guest. */
-                                LogFunc(("Host indicated that operation was cancelled\n", rc));
+                                LogFunc(("Host indicated that operation was cancelled\n"));
                             }
                             else