Changeset 98084 in vbox

Timestamp:

Jan 15, 2023 2:23:39 AM (2 years ago)

Author:

vboxsync

Message:

Main/ConsoleImpl: Another small getDeviceActivity optimization, reducing the code by 16 bytes on windows. bugref:9892

File:

• trunk/src/VBox/Main/src-client/ConsoleImpl.cpp (modified) (6 diffs)

trunk/src/VBox/Main/src-client/ConsoleImpl.cpp

@@ -2832 +2832 @@
      */
 
-    /* Make a roadmap of which DeviceType_T LED types are wanted */
-    DeviceType_T maxWanted = (DeviceType_T)0;
-    bool aWanted[DeviceType_End] = { 0 };
-    Assert(aWanted[1] == false && aWanted[DeviceType_End - 1] == false);
+    /*
+     * Make a roadmap of which DeviceType_T LED types are wanted:
+     */
+    uint32_t fWanted = 0;
+    AssertCompile(DeviceType_End <= 32);
 
     for (size_t iType = 0; iType < aType.size(); ++iType)
@@ -2842 +2843 @@
         AssertReturn(enmType > DeviceType_Null && enmType < DeviceType_End,
                      setError(E_INVALIDARG, tr("Invalid DeviceType for getDeviceActivity in entry #%u: %d"), iType, enmType));
-        aWanted[enmType] = true;
-        if (enmType > maxWanted)
-            maxWanted = enmType;
+        fWanted |= RT_BIT_32((unsigned)enmType);
     }
 
@@ -2850 +2849 @@
     aActivity.resize(aType.size());
 
-    /* Collect all the LEDs in a single sweep through all drivers' sets */
+    /*
+     * Collect all the LEDs in a single sweep through all drivers' sets:
+     */
     PDMLEDCORE aLEDs[DeviceType_End] = { {0} };
     Assert(aLEDs[1].u32 == 0 && aLEDs[DeviceType_End / 2].u32 == 0 && aLEDs[DeviceType_End - 1].u32 == 0); /* paranoia */
@@ -2864 +2865 @@
             {
                 DeviceType_T const enmType = pLS->paSubTypes[inSet];
-                if (enmType < maxWanted && aWanted[enmType])
+                Assert((unsigned)enmType < (unsigned)DeviceType_End);
+                if (fWanted & RT_BIT_32((unsigned)enmType))
                     aLEDs[enmType].u32 |= readAndClearLed(pLS->papLeds[inSet]);
             }
@@ -2872 +2874 @@
         {
             DeviceType_T const enmType = pLS->enmType;
-            if (enmType < maxWanted && aWanted[enmType])
+            Assert((unsigned)enmType < (unsigned)DeviceType_End);
+            if (fWanted & RT_BIT_32((unsigned)enmType))
                 for (uint32_t inSet = 0; inSet < pLS->cLeds; ++inSet)
                     aLEDs[enmType].u32 |= readAndClearLed(pLS->papLeds[inSet]);
@@ -2878 +2881 @@
     }
 
-    /* Compose the result vector: */
+    /*
+     * Compose the result vector:
+     */
     for (size_t iType = 0; iType < aActivity.size(); ++iType)
     {