Changeset 98085 in vbox

Timestamp:

Jan 15, 2023 2:42:44 AM (23 months ago)

Author:

vboxsync

Message:

Main/ConsoleImpl: Added @todo's to getDeviceActivity regarding outstanding issues. bugref:9892

File:

• trunk/src/VBox/Main/src-client/ConsoleImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-client/ConsoleImpl.cpp

@@ -2831 +2831 @@
      * readAndClearLed() should be thread safe.
      */
+/** @todo r=bird: readAndClearLed is safe, provided that we're not running at the
+ * same time as Console::i_allocateDriverLeds.  This assumption is not correct
+ * during VM construction. */
 
     /*
@@ -2862 +2865 @@
         if (pLS->paSubTypes)
         {
+/** @todo r=bird: This needs optimizing as it hurts to scan all units of all
+ * storage controllers when getting the activitiy of one or more non-storage
+ * devices.
+ *
+ * Perhaps add a type summary bitmap to the entry, or may just reuse the
+ * enmType for these. */
             for (uint32_t inSet = 0; inSet < pLS->cLeds; ++inSet)
             {