Changeset 98101 in vbox for trunk/src/VBox/Main

Timestamp:

Jan 17, 2023 10:59:59 AM (2 years ago)

Author:

vboxsync

Message:

Main/IMachine::attachDevice: Attempt at fixing r150710 regression. Looks like fHotplug was incorrectly set just to make USB media attachments always hotpluggable, with the result that attaching an MSD while the VM was powered off caused media to be in a locked state when it shouldn't and prevent the machine from powering up. bugref:8211

File:

• trunk/src/VBox/Main/src-server/MachineImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-server/MachineImpl.cpp

@@ -3890 +3890 @@
                         aName.c_str());
 
-    /* Attaching a USB device when a VM is powered off should default to being marked as hot-pluggable */
-    if (!fHotplug && !Global::IsOnlineOrTransient(mData->mMachineState) && ctrlType == StorageControllerType_USB)
-        fHotplug = true;
-
     // check that the port and device are not out of range
     rc = ctl->i_checkPortAndDeviceValid(aControllerPort, aDevice);
@@ -4348 +4344 @@
                           false /* fNonRotational */,
                           false /* fDiscard */,
-                          fHotplug /* fHotPluggable */,
+                          fHotplug || ctrlType == StorageControllerType_USB /* fHotPluggable */,
                           Utf8Str::Empty);
     if (FAILED(rc)) return rc;