Changeset 98271 in vbox for trunk/src/VBox/Devices/Storage

Timestamp:

Jan 24, 2023 10:08:42 AM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

155474

Message:

Devices/Storage: Suspend the VM when the file handle became stale (often due to a restarted MFS server), bugref:9811

Location:

trunk/src/VBox/Devices/Storage

Files:

• DevATA.cpp (modified) (2 diffs)
• DrvVD.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Storage/DevATA.cpp

@@ -1723 +1723 @@
 }
 
+static void ataR3WarningFileStale(PPDMDEVINS pDevIns)
+{
+    int rc;
+    LogRel(("PIIX3 ATA: File handle became stale\n"));
+    rc = PDMDevHlpVMSetRuntimeError(pDevIns, VMSETRTERR_FLAGS_SUSPEND | VMSETRTERR_FLAGS_NO_WAIT, "DevATA_FILESTALE",
+                                    N_("The file became stale (often due to a restarted NFS server). VM execution is suspended. You can resume when it is available again"));
+    AssertRC(rc);
+}
+
+
 static bool ataR3IsRedoSetWarning(PPDMDEVINS pDevIns, PATACONTROLLER pCtl, int rc)
 {
@@ -1744 +1754 @@
          * connection (second error). Pause VM. On resume we'll retry. */
         ataR3WarningISCSI(pDevIns);
+        return true;
+    }
+    if (rc == VERR_STALE_FILE_HANDLE)
+    {
+        pCtl->fRedoIdle = true;
+        ataR3WarningFileStale(pDevIns);
         return true;
     }

trunk/src/VBox/Devices/Storage/DrvVD.cpp

@@ -2305 +2305 @@
 }
 
+static void drvvdMediaExIoReqWarningFileStale(PPDMDRVINS pDrvIns)
+{
+    int rc;
+    LogRel(("VD#%u: File handle became stale\n", pDrvIns->iInstance));
+    rc = PDMDrvHlpVMSetRuntimeError(pDrvIns, VMSETRTERR_FLAGS_SUSPEND | VMSETRTERR_FLAGS_NO_WAIT, "DrvVD_ISCSIDOWN",
+                                    N_("The file became stale (often due to a restarted NFS server). VM execution is suspended. You can resume when it is available again"));
+    AssertRC(rc);
+}
+
 static void drvvdMediaExIoReqWarningDekMissing(PPDMDRVINS pDrvIns)
 {
@@ -2342 +2351 @@
         if (ASMAtomicCmpXchgBool(&pThis->fRedo, true, false))
             drvvdMediaExIoReqWarningISCSI(pThis->pDrvIns);
+        return true;
+    }
+    if (rc == VERR_STALE_FILE_HANDLE)
+    {
+        if (ASMAtomicCmpXchgBool(&pThis->fRedo, true, false))
+            drvvdMediaExIoReqWarningFileStale(pThis->pDrvIns);
         return true;
     }