Changeset 98406 in vbox

Timestamp:

Feb 1, 2023 3:19:32 PM (2 years ago)

Author:

vboxsync

Message:

Audio: Fixed race condition between announcing remaining device DMA data on draining and fetching it in the async I/O mixer thread via AudioMixerSinkTransferFromCircBuf(). This is due to the device's DMA buffer being reset via its device-specific functions (i.e. ichac97R3StreamReset()) immediately after disabling the stream (i.e. ichac97R3StreamDisable()). See comment 2 for more details [Doxygen fix]. bugref:10354

File:

• trunk/src/VBox/Devices/Audio/AudioMixer.cpp (modified) (2 diffs)

trunk/src/VBox/Devices/Audio/AudioMixer.cpp

@@ -2053 +2053 @@
  * @returns VBox status code.
  * @param   pSink       The mixer sink which AIO thread needs waiting on.
- * @þaram   msTimeout   Timeout (in ms) to use for waiting on draining to be finished.
+ * @param   msTimeout   Timeout (in ms) to use for waiting on draining to be finished.
  *
  * @note    Caller holds the sink's lock.
@@ -2086 +2086 @@
  * @returns VBox status code.
  * @param   pSink       The mixer sink which AIO thread needs waiting on.
- * @þaram   msTimeout   Timeout (in ms) to use for waiting on draining to be finished.
+ * @param   msTimeout   Timeout (in ms) to use for waiting on draining to be finished.
  */
 int AudioMixerSinkWaitForDrained(PAUDMIXSINK pSink, RTMSINTERVAL msTimeout)