Changeset 98480 in vbox

Timestamp:

Feb 6, 2023 6:01:43 PM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

155737

Message:

VMM/IEM: Corrected values of X86_SSE_ROUNDXX_* constants for roundxx SSE instructions, bugref:9898

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllAImplC.cpp (modified) (5 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllAImplC.cpp

@@ -17132 +17132 @@
  */
 
-#define X86_SSE_ROUNDXX_IMM_RC_MASK    UINT32_C(0x0003)
-#define X86_SSE_ROUNDXX_IMM_ROUND_SEL  UINT32_C(0x0004)
-#define X86_SSE_ROUNDXX_IMM_PRECISION  UINT32_C(0x0008)
+#define X86_SSE_ROUNDXX_IMM_RC_MASK    UINT8_C(0x03)
+#define X86_SSE_ROUNDXX_IMM_ROUND_SEL  UINT8_C(0x04)
+#define X86_SSE_ROUNDXX_IMM_PRECISION  UINT8_C(0x08)
+
+#define X86_SSE_ROUNDXX_IMM_MASK       UINT8_C(0x0F)
 
 DECLINLINE(softfloat_state_t) iemSseRoundXXMxcsrAndImmToSoftState(uint32_t fMxcsr, uint8_t bImm)
@@ -17177 +17179 @@
 IEM_DECL_IMPL_DEF(void, iemAImpl_roundss_u128,(uint32_t *pfMxcsr, PX86XMMREG puDst, PCIEMMEDIAF2XMMSRC pSrc, uint8_t bImm))
 {
-    puDst->ar32[0] = iemAImpl_round_worker_r32(pfMxcsr, &pSrc->uSrc2.ar32[0], bImm & 0x7);
+    puDst->ar32[0] = iemAImpl_round_worker_r32(pfMxcsr, &pSrc->uSrc2.ar32[0], bImm & X86_SSE_ROUNDXX_IMM_MASK);
     puDst->au32[1] = pSrc->uSrc1.au32[1];
     puDst->au64[1] = pSrc->uSrc1.au64[1];
@@ -17185 +17187 @@
 IEM_DECL_IMPL_DEF(void, iemAImpl_roundsd_u128,(uint32_t *pfMxcsr, PX86XMMREG puDst, PCIEMMEDIAF2XMMSRC pSrc, uint8_t bImm))
 {
-    puDst->ar64[0] = iemAImpl_round_worker_r64(pfMxcsr, &pSrc->uSrc2.ar64[0], bImm & 0x7);
+    puDst->ar64[0] = iemAImpl_round_worker_r64(pfMxcsr, &pSrc->uSrc2.ar64[0], bImm & X86_SSE_ROUNDXX_IMM_MASK);
     puDst->au64[1] = pSrc->uSrc1.au64[1];
 }
@@ -17194 +17196 @@
     for (uint8_t i = 0; i < RT_ELEMENTS(puDst->ar32); i++)
     {
-        puDst->ar32[i] = iemAImpl_round_worker_r32(pfMxcsr, &pSrc->uSrc2.ar32[i], bImm & 0x7);
+        puDst->ar32[i] = iemAImpl_round_worker_r32(pfMxcsr, &pSrc->uSrc2.ar32[i], bImm & X86_SSE_ROUNDXX_IMM_MASK);
     }
 }
@@ -17203 +17205 @@
     for (uint8_t i = 0; i < RT_ELEMENTS(puDst->ar64); i++)
     {
-        puDst->ar64[i] = iemAImpl_round_worker_r64(pfMxcsr, &pSrc->uSrc2.ar64[i], bImm & 0x7);
+        puDst->ar64[i] = iemAImpl_round_worker_r64(pfMxcsr, &pSrc->uSrc2.ar64[i], bImm & X86_SSE_ROUNDXX_IMM_MASK);
     }
 }