Changeset 98521 in vbox for trunk/src/VBox/VMM/VMMAll

Timestamp:

Feb 10, 2023 9:12:02 AM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

155790

Message:

VMM/IEM: Nested VMX: bugref:10318 Fixed incorrect assumption of secondary VM-exec controls when 'activate secondary controls' isn't set with non-zero secondary value present.

File:

• trunk/src/VBox/VMM/VMMAll/IEMAllCImplVmxInstr.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/VMMAll/IEMAllCImplVmxInstr.cpp

@@ -6341 +6341 @@
 static int iemVmxVmentryCheckCtls(PVMCPUCC pVCpu, const char *pszInstr) RT_NOEXCEPT
 {
-    PCVMXVVMCS const pVmcs = &pVCpu->cpum.GstCtx.hwvirt.vmx.Vmcs;
+    PVMXVVMCS const pVmcs = &pVCpu->cpum.GstCtx.hwvirt.vmx.Vmcs;
     const char * const pszFailure = "VMFail";
     bool const fVmxTrueMsrs       = RT_BOOL(pVCpu->cpum.GstCtx.hwvirt.vmx.Msrs.u64Basic & VMX_BF_BASIC_TRUE_CTLS_MASK);
@@ -6395 +6395 @@
         }
         else
-            Assert(!pVmcs->u32ProcCtls2);
+        {
+            /*
+             * If the "activate secondary controls" is clear, then the secondary processor-based VM-execution controls
+             * is treated as 0. We must not fail/assert here. Microsoft Hyper-V relies on this behavior.
+             *
+             * See Intel spec. 26.2.1.1 "VM-Execution Control Fields".
+             */
+            pVmcs->u32ProcCtls2 = 0;
+        }
 
         /* CR3-target count. */