Changeset 98536 in vbox

Timestamp:

Feb 10, 2023 5:39:28 PM (2 years ago)

Author:

vboxsync

svn:sync-xref-src-repo-rev:

155813

Message:

testmanager/status.py: Dropping unused cHoursBack argument to the select as its %s was dropped by r154325. bugref:10364

File:

• trunk/src/VBox/ValidationKit/testmanager/cgi/status.py (modified) (3 diffs)

trunk/src/VBox/ValidationKit/testmanager/cgi/status.py

@@ -284 +284 @@
         # Get the data.
         #
-        # Note! We're not joining on TestBoxesWithStrings.idTestBox =
-        #       TestSets.idGenTestBox here because of indexes.  This is
-        #       also more consistent with the rest of the query.
+        # - The first part of the select is about fetching all finished tests
+        #   for last cHoursBack hours
+        #
+        # - The second part is fetching all tests which isn't done. (Both old
+        #   (running more than cHoursBack) and fresh (less than cHoursBack) ones
+        #   because we want to know if there's a hanging tests together with
+        #   currently running).
+        #
+        # - There are also testsets without status at all, likely because disabled
+        #   testboxes still have an assigned testsets.
+        #
+        # Note! We're not joining on TestBoxesWithStrings.idTestBox = TestSets.idGenTestBox
+        #       here because of indexes.  This is also more consistent with the
+        #       rest of the query.
+        #
         # Note! The original SQL is slow because of the 'OR TestSets.tsDone'
         #       part, using AND and UNION is significatly faster because
@@ -295 +307 @@
             return False;
 
-        #
-        # some comments regarding select below:
-        # first part is about fetching all finished tests for last cHoursBack hours
-        # second part is fetching all tests which isn't done
-        # both old (running more than cHoursBack) and fresh (less than cHoursBack) ones
-        # 'cause we want to know if there's a hanging tests together with currently running
-        #
-        # there's also testsets without status at all, likely because disabled testboxes still have an assigned testsets
-        #
         oDb.execute('''
 (   SELECT  TestBoxesWithStrings.sName,
@@ -350 +353 @@
       AND   SchedGroupNames.idTestBox = TestBoxesWithStrings.idTestBox
 )
-''', (cHoursBack, cHoursBack,));
+''', (cHoursBack, ));