Changeset 98574 in vbox for trunk/src/VBox/HostServices/GuestControl

Timestamp:

Feb 15, 2023 12:24:25 AM (2 years ago)

Author:

vboxsync

Message:

HGCMMock.h,tstGuestControlMockHGCM: Fixed memory overrun wrt client memory. Quick fix for use-after-free wrt call parameters (may still leak stuff because the code seems a bit uncertain about who does what). Disabled some non-working copy-paste tests.

File:

• trunk/src/VBox/HostServices/GuestControl/testcase/tstGuestControlMockHGCM.cpp (modified) (11 diffs)

trunk/src/VBox/HostServices/GuestControl/testcase/tstGuestControlMockHGCM.cpp

@@ -26 +26 @@
  */
 
+
+/*********************************************************************************************************************************
+*   Header Files                                                                                                                 *
+*********************************************************************************************************************************/
 #include <VBox/HostServices/GuestControlSvc.h>
 #include <VBox/VBoxGuestLib.h>
@@ -51 +55 @@
 *   Shared Clipboard testing                                                                                                     *
 *********************************************************************************************************************************/
+/** @todo r=bird: Clipboard?  */
+
 struct CLIPBOARDTESTDESC;
 /** Pointer to a test description. */
@@ -103 +109 @@
 CLIPBOARDTESTCTX g_TstCtx;
 
+#if 0 /** @todo r=bird: Clipboard? This times out and asserts and doesn't seems to do anything sensible. */
+
 /**
  * Structure for keeping a clipboard test description.
@@ -120 +128 @@
 } SHCLCONTEXT;
 
+#endif
+
 
 static void testGuestSimple(void)
@@ -155 +165 @@
  * Test: Guest reading from host                                                                                                 *
  ********************************************************************************************************************************/
+/** @todo r=bird: Reading from the host? WTF?  Doesn't seem to work, so I've disabled it till it can be rewritten and
+ * made to do something useful rather than asserting. */
+#if 0
 typedef struct TSTUSERMOCK
 {
@@ -193 +206 @@
 {
     RT_NOREF(pTstCtx, ppvCtx);
-
-    int rc = VINF_SUCCESS;
-
-    return rc;
+    return VINF_SUCCESS;
 }
 
@@ -233 +243 @@
 }
 
+#endif
+
 
 /*********************************************************************************************************************************
  * Main                                                                                                                          *
  ********************************************************************************************************************************/
+#if 0 /** @todo r=bird: Same as above.  */
 
 /** Test definition table. */
@@ -265 +278 @@
 }
 
-int main(int argc, char *argv[])
+#endif
+
+int main()
 {
     /*
      * Init the runtime, test and say hello.
      */
-    const char *pcszExecName;
-    NOREF(argc);
-    pcszExecName = strrchr(argv[0], '/');
-    pcszExecName = pcszExecName ? pcszExecName + 1 : argv[0];
-    RTEXITCODE rcExit = RTTestInitAndCreate(pcszExecName, &g_hTest);
+    RTEXITCODE rcExit = RTTestInitAndCreate("tstGuestControlMockHGCM", &g_hTest);
     if (rcExit != RTEXITCODE_SUCCESS)
         return rcExit;
     RTTestBanner(g_hTest);
 
-#ifndef DEBUG_andy
+#if 0 //ndef DEBUG_andy - bird: fix the 'ing code.
     /* Don't let assertions in the host service panic (core dump) the test cases. */
     RTAssertSetMayPanic(false);
@@ -285 +296 @@
 
     PTSTHGCMMOCKSVC const pSvc = TstHgcmMockSvcInst();
-
-    TstHgcmMockSvcCreate(pSvc, 42 /** @todo */);
+    TstHgcmMockSvcCreate(pSvc);
     TstHgcmMockSvcStart(pSvc);
 
@@ -298 +308 @@
     }
 
+#if 0 /** @todo r=bird: Clipboard? This times out and asserts and doesn't seems to do anything sensible. */
     RT_ZERO(g_TstCtx);
 
@@ -311 +322 @@
 
     TstHGCMUtilsTaskDestroy(pTask);
+#endif
 
     TstHgcmMockSvcStop(pSvc);