Changeset 98587 in vbox

Timestamp:

Feb 15, 2023 1:23:05 PM (22 months ago)

Author:

vboxsync

Message:

HostServices/TstHGCMMock.cpp: fixed memory leak that upsets the tests in asan builds and documented ownership assumptions surrounding it.

File:

• trunk/src/VBox/HostServices/testcase/TstHGCMMock.cpp (modified) (2 diffs)

trunk/src/VBox/HostServices/testcase/TstHGCMMock.cpp

@@ -192 +192 @@
     pFn->u.Call.hCall    = callHandle;
     pFn->u.Call.iFunc    = function;
+    pFn->u.Call.cParms   = cParms;
     PVBOXHGCMSVCPARM const paParmsCopy = (PVBOXHGCMSVCPARM)RTMemDup(paParms, cbParms);
     pFn->u.Call.pParms   = paParmsCopy;
-    AssertPtrReturn(pFn->u.Call.pParms, VERR_NO_MEMORY);
-    pFn->u.Call.cParms   = cParms;
+    AssertPtrReturn(paParmsCopy, VERR_NO_MEMORY);
 
     RTListAppend(&pSvc->lstCall, &pFn->Node);
+    pFn = NULL; /* Thread takes ownership now. We keep ownership of paParmsCopy. */
 
     int rc2 = RTSemEventSignal(pSvc->hEventQueue);
@@ -206 +207 @@
 
     memcpy(paParms, paParmsCopy, cbParms);
-    /** @todo  paParmsCopy is leaked, right? Doesn't appear to be a
-     *         use-after-free here. (pFn is freeded though) */
+    RTMemFree(paParmsCopy);
 
     return VINF_SUCCESS; /** @todo Return host call rc */