Changeset 98590 in vbox for trunk/src/VBox/ValidationKit/testmanager

Timestamp:

Feb 15, 2023 2:06:04 PM (2 years ago)

Author:

vboxsync

Message:

vsheriff: More general failure reason failure for GA tests.

File:

• trunk/src/VBox/ValidationKit/testmanager/batch/virtual_test_sheriff.py (modified) (4 diffs)

trunk/src/VBox/ValidationKit/testmanager/batch/virtual_test_sheriff.py

@@ -619 +619 @@
 
     ktReason_Add_Installer_Win_Failed                  = ( 'Additions',         'Win GA install' );
+    ktReason_Add_ShFl                                  = ( 'Additions',         'ShFl' );
     ktReason_Add_ShFl_Automount                        = ( 'Additions',         'Automounting' );
     ktReason_Add_ShFl_FsPerf                           = ( 'Additions',         'FsPerf' );
@@ -1232 +1233 @@
 
 
+    ## Fallback reasons based on GA test groups.
+    kdGATestFallbacks = {
+        'Guest Control':  ktReason_Add_GstCtl,
+        'Shared Folders': ktReason_Add_ShFl,
+    };
+
     def investigateGATest(self, oCaseFile, oFailedResult, sResultLog):
         """
@@ -1260 +1267 @@
         elif oFailedResult.sName.find('Session w/ Guest Reboot') >= 0:
             enmReason = self.ktReason_Add_GstCtl_Session_Reboot;
-        elif sParentName == 'Guest Control' or oFailedResult.sName == 'Guest Control':
-            enmReason = self.ktReason_Add_GstCtl;
         # shared folders:
         elif sParentName == 'Shared Folders' and oFailedResult.sName == 'Automounting':
@@ -1275 +1280 @@
         if enmReason is not None:
             return oCaseFile.noteReasonForId(enmReason, oFailedResult.idTestResult);
+
+        # Generalistic fallbacks:
+        for sKey in self.kdGATestFallbacks:
+            oTmpFailedResult = oFailedResult;
+            while oTmpFailedResult:
+                if oTmpFailedResult.sName == sKey:
+                    return oCaseFile.noteReasonForId(self.kdGATestFallbacks[sKey], oFailedResult.idTestResult);
+                oTmpFailedResult = oTmpFailedResult.oParent;
 
         self.vprint(u'TODO: Cannot place GA failure idTestResult=%u - %s' % (oFailedResult.idTestResult, oFailedResult.sName,));