Changeset 98591 in vbox for trunk/src/VBox/ValidationKit

Timestamp:

Feb 15, 2023 2:29:49 PM (2 years ago)

Author:

vboxsync

Message:

vsheriff: More general failure reason failure VBox install/uninstall.

File:

• trunk/src/VBox/ValidationKit/testmanager/batch/virtual_test_sheriff.py (modified) (3 diffs)

trunk/src/VBox/ValidationKit/testmanager/batch/virtual_test_sheriff.py

@@ -654 +654 @@
     ktReason_Host_InvalidPackage                       = ( 'Host',              'ERROR_INSTALL_PACKAGE_INVALID' );
     ktReason_Host_InstallSourceAbsent                  = ( 'Host',              'ERROR_INSTALL_SOURCE_ABSENT' );
+    ktReason_Host_Install_Hang                         = ( 'Host',              'Install hang' );
     ktReason_Host_NotSignedWithBuildCert               = ( 'Host',              'Not signed with build cert' );
     ktReason_Host_DiskFull                             = ( 'Host',              'Host disk full' );
@@ -661 +662 @@
     ktReason_Host_Reboot_OSX_Watchdog_Timeout          = ( 'Host Reboot',       'OSX Watchdog Timeout' );
     ktReason_Host_Modprobe_Failed                      = ( 'Host',              'Modprobe failed' );
-    ktReason_Host_Install_Hang                         = ( 'Host',              'Install hang' );
     ktReason_Host_NetworkMisconfiguration              = ( 'Host',              'Network misconfiguration' );
     ktReason_Host_TSTInfo_Accuracy_OOR                 = ( 'Host',              'TSTInfo accuracy out of range' );
+    ktReason_Host_UninstallationFailed                 = ( 'Host',              'Uninstallation failed' );
     ktReason_Networking_Nonexistent_host_nic           = ( 'Networking',        'Nonexistent host networking interface' );
     ktReason_Networking_VERR_INTNET_FLT_IF_NOT_FOUND   = ( 'Networking',        'VERR_INTNET_FLT_IF_NOT_FOUND' );
@@ -926 +927 @@
                     return True;
                 fFoundSomething = True;
+
+        # If we didn't find something specific, just add a general install/uninstall
+        # failure reason so it's easier to get an idea why a test failed when
+        # looking at the failure listing in the test manager.
+        if not fFoundSomething:
+            if fInstall:
+                oCaseFile.noteReasonForId(self.ktReason_Host_InstallationFailed, oFailedResult.idTestResult);
+            else:
+                oCaseFile.noteReasonForId(self.ktReason_Host_UninstallationFailed, oFailedResult.idTestResult);
 
         return fFoundSomething if fFoundSomething else None;